Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1321013 - Review request: gnome-shell-extension-taskbar - GNOME Shell Extension TaskBar
Summary: Review request: gnome-shell-extension-taskbar - GNOME Shell Extension TaskBar
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2016-03-24 13:24 UTC by zpydr
Modified: 2019-02-25 17:00 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-25 17:00:01 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description zpydr 2016-03-24 13:24:44 UTC 
Spec URL: 
https://github.com/zpydr/gnome-shell-extension-taskbar-rpm/raw/7e50abaa0825958e981266b71491dcc091b25122/gnome-shell-extension-taskbar.spec

SRPM URL: 
https://github.com/zpydr/gnome-shell-extension-taskbar-rpm/raw/7e50abaa0825958e981266b71491dcc091b25122/gnome-shell-extension-taskbar-50.1-1.fc23.src.rpm

Description: 
TaskBar displays icons of running applications on the top panel.
https://extensions.gnome.org/extension/584/taskbar/

Fedora Account System Username: 
zpydr

Thank you for taking your time to review this package.
Comment 1 Scott Williams 2016-04-08 21:47:32 UTC 
A good start.  Here's my initial comments:

The mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/TaskBar@zpydr/ line is unnecessary since other mkdir -p will generate it

It is not usual nomenclature to have an '@' in a filesystem path, especially when the @ appears to be your username.  It's uncommon to have '@' in a fs path, but it looks like other Gnome extensions use this.  I did notice, however, that the extensions generally point back to an upstream URL rather than a username, such as a GitHub account, but I do see an exception in gnome-shell-extension-pidgin, where the username is used instead.  I don't see anything in the packaging guidelines against this, but bringing it up to show what other existing gnome extension packages are doing.

For the language support, since you just have a few, you should use %find_lang (See https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files )

Otherwise, rpmlint shows no errors.
Comment 2 Zbigniew Jędrzejewski-Szmek 2016-11-13 23:36:30 UTC 
Do you still plan to get this package into Fedora?
Comment 3 zpydr 2016-11-14 08:24:37 UTC 
Yes I do want to get TaskBar into Fedora, but unfortunately I am very busy for the time being.
Comment 4 zpydr 2016-11-17 15:10:40 UTC 
Spec URL: 
https://raw.githubusercontent.com/zpydr/gnome-shell-extension-taskbar-rpm/master/gnome-shell-extension-taskbar.spec

SRPM URL: 
https://github.com/zpydr/gnome-shell-extension-taskbar-rpm/blob/master/gnome-shell-extension-taskbar-53.0-1.fc24.src.rpm?raw=true

Description: 
TaskBar displays icons of running applications on the top panel.
https://extensions.gnome.org/extension/584/taskbar/

Fedora Account System Username: 
zpydr

I have updated the files according to Scott's comment. rpmlint shows no errors.
Comment 5 Zbigniew Jędrzejewski-Szmek 2016-11-18 19:04:21 UTC 
Package looks all right, no issues here. But to become a maintainer, so more work would be needed (reviews of other packages). Let me know if you want to do it.
Comment 6 zpydr 2016-11-27 18:36:41 UTC 
Yes absolutely, I've read the relevant documentation.
Comment 7 Carl George 2019-02-25 17:00:01 UTC 
This looks to be dead upstream.

https://github.com/zpydr/gnome-shell-extension-taskbar/commit/eb79254d884dab82e2661969fa0e31374f3bff43

We shouldn't add dead software to Fedora.  I'm going to close this for now, but if you find a maintained fork and would like to pick this back up please re-open it.
Note You need to log in before you can comment on or make changes to this bug.