Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1323254 - lshell: Provide a Python 3 subpackage
Summary: lshell: Provide a Python 3 subpackage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lshell
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3
TreeView+ depends on / blocked
 
Reported: 2016-04-01 15:58 UTC by Tomas Orsava
Modified: 2016-05-20 23:53 UTC (History)
3 users (show)

Fixed In Version: lshell-0.9.18-1.fc24 lshell-0.9.18-1.fc22 lshell-0.9.18-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-20 17:41:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
New release and BugFix. (deleted)
2016-05-07 08:39 UTC, Lumír Balhar
no flags Details | Diff

Description Tomas Orsava 2016-04-01 15:58:02 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Comment 1 Lumír Balhar 2016-05-05 18:59:17 UTC
Hello.

I've found this bug in Fedora portingdb and I've thought that it isn't ported to Python 3 yet but the package is already ported to Python 3.

But I've found another bug in documentation files list, where README instead README.md is listed and this is the reason why package build fails. So I solved this bug and prepare the specfile for new upstream release too.

Here is my patch to original specfile:

$ diff lshell.spec lshell.spec.old 
2,3c2,3
< Version:        0.9.18
< Release:        1%{?dist}
---
> Version:        0.9.17
> Release:        2%{?dist}
29c29
< rm %{buildroot}%{_defaultdocdir}/lshell/{CHANGES,COPYING,README.md}
---
> rm %{buildroot}%{_defaultdocdir}/lshell/{CHANGES,COPYING,README}
54,56d53
< * Thu May 05 2016 Lumír Balhar <frenzy.madness> - 0.9.18-1
< - Updated to new upstream version 0.9.18

Have a nice day.
Lumír

Comment 2 Tomas Orsava 2016-05-06 16:41:31 UTC
Hi Lumir!

Thank you for pointing out that the package is already ported, I will investigate why it is shown incorrectly in the PortingDB.

Concerning the bug you have found, I would suggest you open a new BugZilla report just for it as it is not related to this bug.

And two note on patches:
1. If you want to include a patch on BugZilla, use the "Add an attachment" option above the comments.
2. It is best to make patches using git (commit changes and do `git format-patch HEAD~` for example).
Patches made by git include time, subject, name of the person and above all—you can be sure they are correct.
If you use `diff` you can often switch the order of the files and make a reverse patch, as you posted here. I suggest reviewing the patch in some editor with highlighting: added lines should be green.

Have a great day!
Tomas

Comment 3 Tomas Orsava 2016-05-06 17:05:12 UTC
Hi Fabian,
thank you for taking the time to port your package to Python 3!

However, I have found out that there is no functioning build of the package with this added Python 3 support. When I tried building it in Koji, it fails:

http://koji.fedoraproject.org/koji/taskinfo?taskID=13949522

I would like to ask you to take a look at it. Hopefully it is only the forgotten ".md" extension of the README file on that one line as Lumir pointed out.

Thank you for your time!


And Lumir, as this bug blocks building of the package, you were right to post the patch here.

Comment 4 Petr Viktorin (pviktori) 2016-05-06 17:10:33 UTC
You need to update to the 9.18 release; 9.17 is not py3-compatible.

Comment 5 Lumír Balhar 2016-05-07 08:38:08 UTC
Hi Tomas.

Thank you very much for your advice. This is my first cooperation in the RH Bugzilla so I really appreciate that.

My patch in a correct form will be in attachments in a short while.

Have a nice weekend.
Lumír

Comment 6 Lumír Balhar 2016-05-07 08:39:06 UTC
Created attachment 1154817 [details]
New release and BugFix.

Comment 7 Fedora Update System 2016-05-07 12:57:22 UTC
lshell-0.9.18-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f5ecaae1a

Comment 8 Fedora Update System 2016-05-07 13:10:08 UTC
lshell-0.9.18-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5f046ca688

Comment 9 Fedora Update System 2016-05-07 13:16:03 UTC
lshell-0.9.18-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-619af92d2e

Comment 10 Fedora Update System 2016-05-08 16:26:24 UTC
lshell-0.9.18-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5f046ca688

Comment 11 Fedora Update System 2016-05-08 21:50:34 UTC
lshell-0.9.18-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-619af92d2e

Comment 12 Fedora Update System 2016-05-08 22:23:09 UTC
lshell-0.9.18-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f5ecaae1a

Comment 13 Tomas Orsava 2016-05-09 11:10:40 UTC
Great work, Lumir! Your patch is now in and the lshell package is ported!

And thank you, Fabian, for pushing the patch so quickly!

Comment 14 Fedora Update System 2016-05-20 17:41:47 UTC
lshell-0.9.18-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-05-20 23:51:41 UTC
lshell-0.9.18-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-05-20 23:53:46 UTC
lshell-0.9.18-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.