Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 132770 - speedup patch for vte (makes gnome-terminal usable again)
Summary: speedup patch for vte (makes gnome-terminal usable again)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: vte
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
: 110154 (view as bug list)
Depends On:
Blocks: 131589
TreeView+ depends on / blocked
 
Reported: 2004-09-16 20:06 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:10 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-11-01 21:06:16 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
make vte go fast (zoom, zoom) (deleted)
2004-09-16 20:07 UTC, Tom "spot" Callaway 		no flags Details | Diff
View All

Description Tom "spot" Callaway 2004-09-16 20:06:38 UTC 
The patch found here: http://bugs.gnome.org/show_bug.cgi?id=143914

is a serious performance improvement for vte, and thus, gnome-terminal.

For example, this is the output of time ls -R in the BUILD/vte-0.11.11
directory before the patch:

real    0m0.441s
user    0m0.010s
sys     0m0.013s

...and after the patch:

real    0m0.079s
user    0m0.013s
sys     0m0.006s

Thats roughly an 82% performance increase.

Attached is a version of this patch, ready to apply to rawhide vte.
Comment 1 Tom "spot" Callaway 2004-09-16 20:07:32 UTC 
Created attachment 103930 [details]
make vte go fast (zoom, zoom)
Comment 2 Havoc Pennington 2004-10-28 03:39:44 UTC 
Ouch, definitely should have had this one on the target list. Too late
for FC3, but adding it to target list anyhow and we can do it as an
update or be sure it gets migrated to the FC4 target list.
Comment 3 Warren Togami 2004-10-28 03:50:38 UTC 
What about RHEL4?
Comment 4 Dax Kelson 2004-10-28 05:27:22 UTC 
I don't think that 'ls -R' is a very accurate benchmarking tool.
Waaaay to many kernel caching things can effect it.

[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.323s
user    0m0.185s
sys     0m0.077s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.303s
user    0m0.203s
sys     0m0.091s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.381s
user    0m0.265s
sys     0m0.098s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.464s
user    0m0.308s
sys     0m0.136s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.599s
user    0m0.409s
sys     0m0.149s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.810s
user    0m0.545s
sys     0m0.203s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.798s
user    0m0.538s
sys     0m0.208s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.772s
user    0m0.539s
sys     0m0.200s
[dkelson@mentorng dkelson]$
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.774s
user    0m0.535s
sys     0m0.207s
[dkelson@mentorng dkelson]$ time ls -R /usr/lib > /dev/null
 
real    0m0.787s
user    0m0.550s
sys     0m0.197

To benchmark vte (which I'm greatly in favor of speeding up), make
your gnome-terminal 25x80 then do:

$ time cat /usr/share/dict/linux.words

Run this several times, and discard the first couple results.

BTW, if your X server has a hardware accelerated Xrender extension
then vte get a very nice boost in performance. I could be wrong, but I
think only the binary-only Nvidia drivers fit that criteria.
Comment 5 Panu Matilainen 2004-10-28 11:53:48 UTC 
Well this indeed is quite a dramatic improvement. 
"time cat /usr/share/mime-info/gnome-vfs.keys", originally:
real    0m11.588s
user    0m0.000s
sys     0m0.030s
..and with this patch applied:
real    0m0.836s
user    0m0.000s
sys     0m0.040s

And that's with the file hot in cache and the result is consistent
over consecutive runs. This, um, kicks some serious butt :)
Comment 6 Dan Williams 2004-11-01 04:14:29 UTC 
Ray, can we toss this into rawhide at least?
Comment 7 Warren Togami 2004-11-01 04:35:16 UTC 
Been testing it for a few days, it seems good.
Comment 8 Ray Strode [halfline] 2004-11-01 21:06:16 UTC 
Should be in rawhide now
Comment 9 Warren Togami 2004-11-16 02:14:31 UTC 
*** Bug 110154 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.