Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1332715 (kf5-kdgantt2) - Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
Summary: Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kdgantt2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5-eventviews
TreeView+ depends on / blocked
 
Reported: 2016-05-03 21:49 UTC by Daniel Vrátil
Modified: 2016-05-25 19:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-25 19:20:55 UTC
Type: ---
Embargoed:
rdieter: fedora-review+


Attachments (Terms of Use)

Description Daniel Vrátil 2016-05-03 21:49:48 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kdgantt2.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kdgantt2-16.04.0-1.fc23.src.rpm
Description: KDE PIM library for rendering Gantt graphs
Fedora Account System Username: dvratil

Comment 1 Rex Dieter 2016-05-25 15:09:27 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14249107


naming: ok

sources: ok
c9056f677a6e061811c6f1f6b7b029d3  kdgantt2-16.04.0.tar.xz

license: ok

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

macros: ok

scriptlets: ok

2.  SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes:      kdepim-libs%{?_isa} < 16.04.0
Conflicts:      kdepim-libs%{?_isa} < 16.04.0


Otherwise, pretty simple and clean, follows conventions of other kf5/pim related packages.

APPROVED

Comment 2 Rex Dieter 2016-05-25 15:16:18 UTC
pkgdb request submitted

Comment 3 Gwyn Ciesla 2016-05-25 15:47:15 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kdgantt2

Comment 4 Rex Dieter 2016-05-25 19:20:55 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.