Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1332717 - Review Request: kf5-incidenceeditor - KDE PIM library for creating and editing calendar incidences
Summary: Review Request: kf5-incidenceeditor - KDE PIM library for creating and editin...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kdepim-addons
TreeView+ depends on / blocked
 
Reported: 2016-05-03 21:51 UTC by Daniel Vrátil
Modified: 2016-08-14 16:25 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-25 19:36:31 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)

Description Daniel Vrátil 2016-05-03 21:51:28 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-incidenceeditor.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-incidenceeditor-16.04.0-1.fc23.src.rpm
Description: KDE PIM library for creating and editing calendar incidences
Fedora Account System Username: dvratil
Comment 1 Rex Dieter 2016-05-25 15:19:32 UTC 
gathered depdendencies, and local build succeeds/installs ok.

naming: ok

sources: ok
f0a3c650704e906d191e67364274ac0b  incidenceeditor-16.04.0.tar.xz

license: ok

URL: Not valid
1.  SHOULD fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

macros: ok

scriptlets: ok

2.  SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes:      kdepim-libs%{?_isa} < 16.04.0
Conflicts:      kdepim-libs%{?_isa} < 16.04.0


Otherwise, pretty simple and clean, follows conventions of other kf5/pim related packages.

APPROVED
Comment 2 Rex Dieter 2016-05-25 15:20:43 UTC 
pkgdb request submitted
Comment 3 Gwyn Ciesla 2016-05-25 15:48:18 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-incidenceeditor
Comment 4 Rex Dieter 2016-05-25 19:36:31 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.