Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1332719 (kdepim-apps-libs) - Review Request: kdepim-apps-libs - KDE PIM common libraries
Summary: Review Request: kdepim-apps-libs - KDE PIM common libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: kdepim-apps-libs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews 1332254 kf5-messagelib
TreeView+ depends on / blocked
 
Reported: 2016-05-03 21:53 UTC by Daniel Vrátil
Modified: 2016-05-26 14:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-26 14:20:21 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)

Description Daniel Vrátil 2016-05-03 21:53:08 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kdepim-apps-libs.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kdepim-apps-libs-16.04.0-1.fc23.src.rpm
Description: KDE PIM common libraries 
Fedora Account System Username: dvratil
Comment 1 Rex Dieter 2016-05-25 15:29:59 UTC 
after gathering deps by hand, builds/isntalls locally ok


naming: ok

sources: ok
677cb160d12d5731a296b3f6a24bc270  kdepim-apps-libs-16.04.0.tar.xz

license: ok

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

macros: ok

scriptlets: ok

2.  SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes:      kdepim-libs%{?_isa} < 16.04.0
Conflicts:      kdepim-libs%{?_isa} < 16.04.0


Otherwise, pretty simple and clean, follows conventions of other kf5/pim related packages.

APPROVED
Comment 2 Rex Dieter 2016-05-25 15:42:07 UTC 
pkgdb request submitted
Comment 3 Gwyn Ciesla 2016-05-25 15:56:50 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-apps-lib
Comment 4 Rex Dieter 2016-05-25 18:27:51 UTC 
Arg, looks like the Summary was wrong, so misnamed git module was created.

Resubmitting to pkgdb now :-/
Comment 5 Gwyn Ciesla 2016-05-26 14:10:44 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-apps-libs
Comment 6 Rex Dieter 2016-05-26 14:20:21 UTC 
imported, thanks.
Note You need to log in before you can comment on or make changes to this bug.