Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1338556 - Review Request: mod_ical - Apache iCal/jCal/xCal filter module
Summary: Review Request: mod_ical - Apache iCal/jCal/xCal filter module
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2016-05-22 18:52 UTC by Graham Leggett
Modified: 2020-08-10 00:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:55:29 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Graham Leggett 2016-05-22 18:52:39 UTC 
Spec URL: https://github.com/minfrin/mod_ical/blob/master/mod_ical.spec
SRPM URL: https://github.com/minfrin/mod_ical/releases/download/mod_ical-0.0.6/mod_ical-0.0.6-1.el7.centos.src.rpm
Description: The Apache mod_ical module provides a set of filters to
filter RFC5545 iCalendar data and convert it to
RFC6321 xCal / RFC7265 jCal.
Fedora Account System Username: minfrin
Comment 1 Igor Gnatenko 2016-07-07 18:40:19 UTC 
Please split BuildRequires for one per line.

From first glance looks good. Also you need sponsorship.
Comment 2 Othman Madjoudj 2016-07-15 01:48:19 UTC 
Hi Graham,

I'm not a sponsor so I cant do full review (afaik).
Please consider the following points related to Apache httpd modules packaging best practices (ie: not in the guidelines but should be implemented):

1. You should include a config file that loads the module eg "20-mod_ical.conf", then install it into httpd modules config dir.

# cat 20-mod_ical.conf
LoadModule ical_module modules/mod_ical.so

Spec changes:

...
Source1: 20-mod_ical.conf
...
...
install -Dp -m0644 %{SOURCE1} %{buildroot}%{_httpd_modconfdir}/20-mod_ical.conf
...

2. The module should require httpd binary interface that was built on, ie add:

Requires: httpd-mmn = %{_httpd_mmn}


3. You should use macros instead of hardcoded paths, ie:

Replace "%{_libdir}/httpd/modules/mod_ical.so" with  "%{_httpd_moddir}/mod_ical.so"
Comment 3 Package Review 2020-07-10 00:54:43 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.
Comment 4 Package Review 2020-08-10 00:55:29 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
Note You need to log in before you can comment on or make changes to this bug.