Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1340884 (krita) - Review Request: krita - A sketching and painting program
Summary: Review Request: krita - A sketching and painting program
Keywords:
Status: CLOSED RAWHIDE
Alias: krita
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2016-05-30 14:42 UTC by Helio Chissini de Castro
Modified: 2016-05-31 20:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-31 20:59:31 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)

Description Helio Chissini de Castro 2016-05-30 14:42:46 UTC 
Spec URL: https://heliocastro.fedorapeople.org/krita/krita.spec
SRPM URL: https://heliocastro.fedorapeople.org/krita/krita-3.0-1.fc24.src.rpm
Description: Krita is a FREE sketching and painting program.
Fedora Account System Username: heliocastro
Comment 1 Kevin Kofler 2016-05-30 15:30:51 UTC 
This used to be a part of the calligra package. It has now become a standalone upstream release with Krita 3 (the KF5 port).
Comment 2 Helio Chissini de Castro 2016-05-30 15:39:58 UTC 
Exactly.

That's why the new package
Comment 3 Rex Dieter 2016-05-31 13:23:36 UTC 
I can review, some initial comments:


1.  MUST: drop -devel subpkg, there's no public API (headers), better to omit
%{_libdir}/libkrita*.so
from packaging

2.  SHOULD consider a -libs subpkg, for multilib friendliness, to include shared libraries and plugins, basically:
%{_libdir}/libkrita*.so.*

3.  SHOULD support better upgrade path from calligra-krita, add

Obsoletes: calligra-krita < 3.0
Provides:  calligra-krita = %{version}-%{release}

# add to -libs pkg, if you choose to create one per item 2
Obsoletes: calligra-krita-libs < 3.0
Provides:  calligra-krita-libs = %{version}-%{release}

4.  Source URL invalid, MUST use (something like)
Source0: http://download.kde.org/stable/krita/%{version}/krita-%{version}.tgz
(without this, I cannot verify sources either, since the Source used currently has a different extension .tar.xz)

5.  MUST add missing icon/mimetype/shlib scriptlets:
%post
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :

%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:

%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
fi

and to -libs:
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig

6.  SHOULD simplify Summary/Description, mentioning "FREE" is extraneous (everything in fedora is free already), I'd suggest just
Summary: A sketching and painting program
Comment 4 Helio Chissini de Castro 2016-05-31 14:39:09 UTC 
Updated with all changes:

Spec URL: https://heliocastro.fedorapeople.org/krita/krita.spec
SRPM URL: https://heliocastro.fedorapeople.org/krita/krita-3.0-2.fc24.src.rpm
Comment 5 Rex Dieter 2016-05-31 14:48:40 UTC 
sources: ok
$ md5sum *.tgz
beb7140471d1b6b0ae92d664743c067f  krita-3.0.tgz

naming: ok

license: ok

Looks good, APPROVED
Comment 6 Rex Dieter 2016-05-31 15:08:59 UTC 
pkgdb request submitted
Comment 7 Neal Gompa 2016-05-31 18:25:09 UTC 
Hold on... Why are the krita libraries included in both krita-libs and krita itself? They should only be in krita-libs.
Comment 8 Rex Dieter 2016-05-31 19:19:57 UTC 
you're right, sorry.  I'd only checked that the -libs pkg was created, not that it's contents were removed from the main pkg too.

We can fix that up prior to doing any official builds.
Comment 9 Rex Dieter 2016-05-31 20:59:31 UTC 
importing into rawhide, and fixing up items
Note You need to log in before you can comment on or make changes to this bug.