Hi,

I'd recommend to use latest version of example spec for dashboard packages, which can be found in https://github.com/openstack-packages/openstack-example-spec/blob/master/example-ui.spec. That will help to standardize similar packages.

Some comments:

- Current convention for package names for dashboard projects is -ui instead of -dashboard.
- URL should point to https://github.com/openstack/%{pypi_name} 
- Using python macros and variables as defined in the above example is recommended. 

Note that the examples includes compilation and installation of language files (which i think do not exist in cloudkitty-dashboard) and a separate doc package, which i'm unsure if it's required for this particular case. Those parts of the spec file can be removed.

Best regards,

Alfredo

Thank you for you review! I'll update the spec file ASAP.

Since the upstream name is cloudkitty-dashboard, doesn't it make sense to keep the same name for the RPM package to avoid confusion?

(In reply to Gauvain Pocentek from comment #2)
> Thank you for you review! I'll update the spec file ASAP.
> 

Great, thanks.

> Since the upstream name is cloudkitty-dashboard, doesn't it make sense to
> keep the same name for the RPM package to avoid confusion?

The projects upstream for horizon dashboards use both -dashboard and -ui names. There was a decision to use the same suffix for all these projects to make it easier to search or them. As first projects were -ui, that was the name.

Thanks for the explanation.

The spec file has been updated in the git repo, and the packages generated from master using DLRN:

SRPM URL: http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.1-0.20160613193615.ce32d88.el7.centos.src.rpm

Generated binaries:
- http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.1-0.20160613193615.ce32d88.el7.centos.noarch.rpm
- http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-doc-0.5.1-0.20160613193615.ce32d88.el7.centos.noarch.rpm

Hi,

One last point. I've realized of a missing cleanup for the docs part in the example, as seen https://github.com/openstack-packages/openstack-example-spec/pull/9/commits/63ed877444c7fc0f6913eb1620c4590ef8982011 , could you add it to the spec file, please?

Best regards,

Alfredo

New spec URL (renamed): https://raw.githubusercontent.com/ObjectifLibre/cloudkitty-dashboard/rpm-master/openstack-cloudkitty-ui.spec

And (s)rpms:
- http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.1-0.20160614083052.ce32d88.el7.centos.src.rpm
- http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.1-0.20160614083052.ce32d88.el7.centos.noarch.rpm
- http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-doc-0.5.1-0.20160614083052.ce32d88.el7.centos.noarch.rpm

Spec URL: https://raw.githubusercontent.com/ObjectifLibre/cloudkitty-dashboard/rpm-master/openstack-cloudkitty-ui.spec

SRPM URL: http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.1-0.20160614083052.ce32d88.el7.centos.src.rpm

I think it looks fine now.

Results of fedora-review:

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 19 files have unknown
     license. Detailed output of licensecheck in /tmp/openstack-cloudkitty-
     ui/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-cloudkitty-ui-doc
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     0.5.1.dev1
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: openstack-cloudkitty-ui-0.5.1-0.20160614083052.ce32d88.el7.centos.noarch.rpm
          openstack-cloudkitty-ui-doc-0.5.1-0.20160614083052.ce32d88.el7.centos.noarch.rpm
          openstack-cloudkitty-ui-0.5.1-0.20160614083052.ce32d88.el7.centos.src.rpm
openstack-cloudkitty-ui.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_12_project_reporting_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_rating_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_admin_group.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_13_admin_pyscripts_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_hashmap_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_project_rating_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_31000_cloudkitty.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_project_group.py 640
openstack-cloudkitty-ui-doc.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.src: E: no-changelogname-tag
openstack-cloudkitty-ui.src: W: invalid-url Source0: cloudkitty-dashboard-0.5.1.dev1-0.20160614083052.ce32d88.tar.gz
3 packages and 0 specfiles checked; 11 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
openstack-cloudkitty-ui-doc.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_project_rating_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_13_admin_pyscripts_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_project_group.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_31000_cloudkitty.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_rating_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_hashmap_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_12_project_reporting_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_admin_group.py 0640L
2 packages and 0 specfiles checked; 10 errors, 0 warnings.



Requires
--------
openstack-cloudkitty-ui-doc (rpmlib, GLIBC filtered):

openstack-cloudkitty-ui (rpmlib, GLIBC filtered):
    openstack-dashboard
    python(abi)
    python-cloudkittyclient
    python-pbr



Provides
--------
openstack-cloudkitty-ui-doc:
    openstack-cloudkitty-ui-doc

openstack-cloudkitty-ui:
    openstack-cloudkitty-ui



Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1345815 -r -m epel-7-dlrn-x86_64
Buildroot used: epel-7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6



Note that packages doesn't contain changelog and version and release are XXX because the spec is prepared to build with dlrn.

New URLs for easier review:

Spec URL: https://raw.githubusercontent.com/ObjectifLibre/cloudkitty-dashboard/rpm-master/openstack-cloudkitty-ui.spec

SRPM URL: http://sheldon.objectif-libre.com/~gpocentek/openstack-cloudkitty-ui-0.5.0-1.src.rpm

A slight oversight but Release has missing %dist tag (should be Release: 1%{?dist})

Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 15 files have unknown
     license. Detailed output of licensecheck in /home/haikel/1345815
     -openstack-cloudkitty-ui/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-cloudkitty-ui-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: openstack-cloudkitty-ui-0.5.0-1.noarch.rpm
          openstack-cloudkitty-ui-doc-0.5.0-1.noarch.rpm
          openstack-cloudkitty-ui-0.5.0-1.src.rpm
openstack-cloudkitty-ui.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_hashmap_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_13_admin_pyscripts_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_admin_group.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_project_rating_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_12_project_reporting_panel.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_project_group.py 640
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_rating_panel.py 640
openstack-cloudkitty-ui-doc.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.src: E: no-changelogname-tag
3 packages and 0 specfiles checked; 10 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
openstack-cloudkitty-ui-doc.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui-doc.noarch: W: invalid-url URL: https://github.com/openstack/cloudkitty-dashboard <urlopen error [Errno -2] Name or service not known>
openstack-cloudkitty-ui.noarch: E: no-changelogname-tag
openstack-cloudkitty-ui.noarch: W: invalid-url URL: https://github.com/openstack/cloudkitty-dashboard <urlopen error [Errno -2] Name or service not known>
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_project_rating_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_13_admin_pyscripts_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_project_group.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_rating_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_11_admin_hashmap_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_12_project_reporting_panel.py 0640L
openstack-cloudkitty-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_10_admin_group.py 0640L
2 packages and 0 specfiles checked; 9 errors, 2 warnings.



Requires
--------
openstack-cloudkitty-ui-doc (rpmlib, GLIBC filtered):

openstack-cloudkitty-ui (rpmlib, GLIBC filtered):
    openstack-dashboard
    python(abi)
    python-cloudkittyclient
    python-pbr



Provides
--------
openstack-cloudkitty-ui-doc:
    openstack-cloudkitty-ui-doc

openstack-cloudkitty-ui:
    openstack-cloudkitty-ui



Source checksums
----------------
http://tarballs.openstack.org/cloudkitty-dashboard/cloudkitty-dashboard-0.5.0.tar.gz :
  CHECKSUM(SHA256) this package     : e726014381e97f855fce2d04a8f35e84ea016b294c1a8d80440f01f21aaeaea2
  CHECKSUM(SHA256) upstream package : e726014381e97f855fce2d04a8f35e84ea016b294c1a8d80440f01f21aaeaea2


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1345815 -m rdo-mitaka-el7
Buildroot used: cloud7-openstack-mitaka-el7-build-repo_20520
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Imported and built in DLRN newton.
https://trunk.rdoproject.org/centos7-master/76/69/7669e469e0e5dfe27c76b4d8bf91ecc130cf770d_2f798217/