Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1346150 - nodejs-typeahead.js creates bad symlinks on install
Summary: nodejs-typeahead.js creates bad symlinks on install
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nodejs-typeahead.js
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-14 06:33 UTC by Rick Elrod
Modified: 2016-09-12 13:23 UTC (History)
1 user (show)

Fixed In Version: nodejs-typeahead.js-0.10.5-5.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-12 13:23:27 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Rick Elrod 2016-06-14 06:33:03 UTC 
Description of problem:

The package creates bad symlinks when installed:

[root@relrod-test SPECS]# ll /usr/lib/node_modules/typeahead.js
total 4
lrwxrwxrwx. 1 root root   26 Jun 17  2015 dist -> /usr/share/javascript/dist
-rw-r--r--. 1 root root 1459 Aug  8  2014 package.json
lrwxrwxrwx. 1 root root   25 Jun 17  2015 src -> /usr/share/javascript/src

The directories /usr/share/javascript/dist and /usr/share/javascript/src don't exist and should be /usr/share/javascript/typeahead.js/dist and /usr/share/javascript/typeahead.js/src respectively.

Version-Release number of selected component (if applicable):
  nodejs-typeahead.js.noarch 0.10.5-3.fc23
Comment 1 Dan Callaghan 2016-07-11 03:44:54 UTC 
Thanks for the repo. Just a dumb typo I made in the spec.


--- a/nodejs-typeahead.js.spec
+++ b/nodejs-typeahead.js.spec
@@ -76,7 +76,7 @@ mkdir -p %{buildroot}%{_jsdir}/%{modname}
 cp -pr src/ dist/ %{buildroot}%{_jsdir}/%{modname}/
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{modname}
 cp -p package.json %{buildroot}%{nodejs_sitelib}/%{modname}/
-ln -s %{_jsdir}/src %{_jsdir}/dist %{buildroot}%{nodejs_sitelib}/%{modname}/
+ln -s %{_jsdir}/%{modname}/src %{_jsdir}/%{modname}/dist %{buildroot}%{nodejs_sitelib}/%{modname}/
 %nodejs_symlink_deps
 
 %files


Tests are unfortunately not executed in %check because they need a browser. I will see if I can at least require() the module in %check as a last resort kind of sanity check.

But even more unfortunately, nodejs-typeahead.js FTBFS right now because of a separate bug in grunt-contrib-uglify: bug 1295295. :-(
Comment 2 Dan Callaghan 2016-07-11 03:48:09 UTC 
(In reply to Dan Callaghan from comment #1)
> Thanks for the repo.

I mean, report.
Comment 3 Dan Callaghan 2016-09-06 01:52:12 UTC 
(In reply to Dan Callaghan from comment #1)
> Tests are unfortunately not executed in %check because they need a browser.
> I will see if I can at least require() the module in %check as a last resort
> kind of sanity check.

Doesn't seem like I can, since it assumes _ and jQuery and window are defined... not even sure how this is supposed to work as an NPM module really...
Comment 4 Dan Callaghan 2016-09-06 02:06:58 UTC 
At this point nodejs-typeahead.js is still FTBFS in F24 so I can only fix this in F25 and rawhide.
Comment 5 Fedora Update System 2016-09-06 02:22:29 UTC 
nodejs-typeahead.js-0.10.5-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ebab72d0d
Comment 6 Fedora Update System 2016-09-07 03:21:46 UTC 
nodejs-typeahead.js-0.10.5-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ebab72d0d
Comment 7 Fedora Update System 2016-09-12 13:23:25 UTC 
nodejs-typeahead.js-0.10.5-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.