I think I should have mentioned explicitly that I'm seeking for a sponsor.

> I'm not sure about how to support old init.d and new systemd based systems in the same time

Upstream solved this in a good way in their spec file: https://github.com/zerotier/ZeroTierOne/blob/master/zerotier-one.spec

Thanks for looking at this, upstream just released a new stable version 4 days ago which I overlooked. Let me have a look at this new spec file (whether it builds with koji, etc.) and come back with an update.

I've been working on the same thing for the last month and was about to open a review request when I found this one. I've been working with upstream on packaging this and dealing with unbundling the included libraries in the `ext` folder and following the Fedora oackaging guidelines to the best of my knowledge and requesting updates to the various dependencies of the packages in rawhide, f24 and epel.

All dependencies are sorted out now in rawhide and available in updates-testing (F24) and epel-testing (EL7).

SPEC: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one.spec
SRPM: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one-1.1.6-2.fc23.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14766141

Upstream is working on builds for other platforms, especially CentOS 6 not using systemd and for customers not wanting to enable EPEL on their machines, that is why there is a spec file in the zerotier repo.

I'm already a Fedora packager and would only require a (formal) review, but am using the `zerotier-one` name as the package name instead of `zerotier`. So not sure if I should open a new request, or we can somehow work together on this?

Upstream bug regarding LDFLAGS override that still needs to be fixed: https://github.com/zerotier/ZeroTierOne/issues/346

I agree, let's stick to upstream, thanks for the update.

EPEL: miniupnpc 2.0 is now available in epel repository, still waiting for json-parser to be moved from epel-testing to epel.

Fedora: miniupnpc 2.0 is not yet pushed to updates for F24, there will be no push to F23.

There are also COPR builds of this, for which currently only the rawhide build works, but the EPEL7 and F24 build should be working shortly if the above is resolved.

https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/

The dependency status:

https://bodhi.fedoraproject.org/updates/?packages=miniupnpc
https://bodhi.fedoraproject.org/updates/?packages=json-parser

Builds on Fedora 24 now as well, not yet on PPC as the tree is not in sync yet.

https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/monitor/

Updated to 1.1.12:

SPEC: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one.spec
SRPM: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one-1.1.12-1.fc23.src.rpm

COPR: https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/build/383005/

The zerotier-one package now also builds on EPEL 7! 

https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/build/385149/

I fixed the LDFLAGS override issue:

SRPM: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one-1.1.12-2.fc23.src.rpm
SPEC: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one.spec

COPR builds:

https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/build/392662/

Update to 1.1.14.

SRPM: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one-1.1.14-1.fc23.src.rpm
SPEC: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one.spec

COPR builds:

https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/build/417412/

SRPM: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one-1.2.2-1.fc25.src.rpm
SPEC: https://fkooman.fedorapeople.org/zerotier-one/zerotier-one.spec

There are some issues with using external libs, a new dependency "json-parser" was added in 1.2.x, I'll try to get the patch upstream for having the ability to use a flag to use the system lib of json-parser, and also http-parser which seemed to have caused issues because distros ship an old version.

Also, the build fails on CentOS 7 due to compiler issues, it seems Clang is needed on CentOS 7 to build ZeroTier.

COPR build: https://copr.fedorainfracloud.org/coprs/fkooman/zerotier/build/528687/

The PR for working with system libraries (work in progress): https://github.com/zerotier/ZeroTierOne/pull/462

Also: lz4 is now embedded in the source code in a namespace in `node/Packet.cpp`: https://github.com/zerotier/ZeroTierOne/blob/cfe0d0971f3ce5972d955250dc1ff6ec7a30e3f7/node/Packet.cpp

 - Please update to version 1.2.4

 - Why do you use a git commit instead of a released version?

Source0:        https://github.com/zerotier/ZeroTierOne/archive/%{version}/%{name}-%{version}.tar.gz

 - make install DESTDIR=$RPM_BUILD_ROOT → %make_install

 - rm -rf $RPM_BUILD_ROOT is not needed in %install

I'm no longer interested in packaging ZeroTier due to disagreement with upstream on how to handle library (un)bundling. 

See https://github.com/zerotier/ZeroTierOne/pull/462

It's their choice of course and I respect that, but I just don't want to spend any time fighting upstream :)

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.