Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1352380 - Review Request: python-parsimonious - a lookahead parser written in pure Python
Summary: Review Request: python-parsimonious - a lookahead parser written in pure Python
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2016-07-04 03:00 UTC by Cody Hiar
Modified: 2020-11-13 00:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Cody Hiar 2016-07-04 03:00:39 UTC 
Spec URL: http://107.170.38.8/python-parsimonious.spec
SRPM URL: http://107.170.38.8/python-parsimonious-0.6.2-1.fc23.src.rpm
Description: 

Hello! I just finished making this package, it's my first one so if there are mistakes please let me know.

Parsimonious aims to be the fastest arbitrary-lookahead parser written in pure Python—and the most usable. It's based on parsing expression grammars (PEGs), which means you feed it a simplified sort of EBNF notation. Parsimonious was designed to undergird a MediaWiki parser that wouldn't take 5 seconds or a GB of RAM to do one page, but it's applicable to all sorts of languages.


Fedora Account System Username: thornycrackers
Comment 1 Eduardo Mayorga 2016-07-11 22:47:40 UTC 
Taking the review. I'll take care of the sponsoring process.

- rpmlint's output is not clean:
python-parsimonious.noarch: W: incoherent-version-in-changelog 0.6.2 ['0.6.2-1.fc25', '0.6.2-1']
  See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

- The package must provide python2-parsimonious. Since there will be Python 3 support in the near future, it's best to create python2-parsimonious and python3-parsimonious subpackages.
  See: https://fedoraproject.org/wiki/Packaging:Python#Provides
  See: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

- I do not understand the point of the conditional. You don't use the value of with_python3 in any place in the Spec.

Please address these issues and I'll review it again.
Comment 2 Package Review 2020-07-10 00:54:55 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 3 Package Review 2020-11-13 00:46:41 UTC 
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.
Note You need to log in before you can comment on or make changes to this bug.