Please note that this package may need a bunch of work, including but not limited to the items already collected through analysis from Tim.

https://bitbucket.org/tflink/phabricator-dist/raw/c21a9d58b00f94fce779ba8b2d01bd54bae8195a/fedora-packaging-notes.rst

To show my general plan for unbundling software; strip the feature if you can (twilio, stripe, amazon-ses), use the packaged versions where appropriate (figlet, pear-figlet), package the software where appropriate (not yet started).

Spec URL: https://kanarip.fedorapeople.org/phabricator/phabricator.spec
SRPM URL: https://kanarip.fedorapeople.org/phabricator/phabricator-20160806.git435f756-1.fc26.src.rpm

Spec URL: https://kanarip.fedorapeople.org/phabricator/phabricator.spec
SRPM URL: https://kanarip.fedorapeople.org/phabricator/phabricator-0.20161126.gitcfcc3b8-2.el7.src.rpm

Spec URL: https://kanarip.fedorapeople.org/phabricator/phabricator.spec
SRPM URL: https://kanarip.fedorapeople.org/phabricator/phabricator-0.20161203.gitad65d93-2.el7.src.rpm

Hello,

I'm not familiar with EPEL requirements, so ignore the things not applying to it.

 - Not needed in Fedora:

   + Group:

   + rm -rf %{buildroot} in %install

   + %clean
     rm -rf %{buildroot}

   + %{!?_licensedir:%global license %doc}

 See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Maybe you should refresh to a more recent git revision.

 - Use systemd macros, use:

%{?systemd_requires}
BuildRequires: systemd

   instead of:

Requires(post):     systemd-units
Requires(postun):   systemd-units
Requires(preun):    systemd-units

BuildRequires:      systemd

 - You should probably clean up all the commented out part.

 - The release tag should start with 0.1 and so on:

Version:            0.1.%{revision_date}.git%{git_short_version_hash}

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.