Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1363763 - Review Request: nodejs-js-beautify - A jsbeautifier.org for node
Summary: Review Request: nodejs-js-beautify - A jsbeautifier.org for node
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1274736 1352696
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2016-08-03 13:44 UTC by Jared Smith
Modified: 2020-11-13 00:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jared Smith 2016-08-03 13:44:12 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-beautify/nodejs-js-beautify.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-beautify/nodejs-js-beautify-1.6.3-1.fc26.src.rpm
Description: A jsbeautifier.org for node
Fedora Account System Username: jsmith

Requesting a re-review, as this package was orphaned.
Comment 1 Jeroen van Meeuwen 2016-08-03 14:59:58 UTC 
No matching package to install: 'npm(benchmark)'
No matching package to install: 'npm(jshint)'
Comment 2 Jeroen van Meeuwen 2016-08-03 15:05:21 UTC 
Please correct the following rpmlint issues:

nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.jshintrc
nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.customignore
nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.jshintignore

nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/build /usr/bin/env node
nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/jshint /usr/bin/env node
nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/land /usr/bin/env node
nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/apply /usr/bin/env node
Comment 3 Jeroen van Meeuwen 2016-08-10 12:26:06 UTC 
Sorry about comment #2...

I suspect these may be required for tests:

nodejs-js-beautify.noarch: E: zero-length /usr/lib/node_modules/js-beautify/js/test/resources/configerror/subDir1/subDir2/empty.txt
nodejs-js-beautify.noarch: E: zero-length /usr/lib/node_modules/js-beautify/js/test/resources/indent11chars/subDir1/subDir2/empty.txt

nodejs-js-beautify.noarch: W: hidden-file-or-dir /usr/lib/node_modules/js-beautify/js/test/resources/configerror/.jsbeautifyrc
nodejs-js-beautify.noarch: W: hidden-file-or-dir /usr/lib/node_modules/js-beautify/js/test/resources/indent11chars/.jsbeautifyrc

But I'm not sure whether these files need to be executable:

nodejs-js-beautify.noarch: E: script-without-shebang /usr/lib/node_modules/js-beautify/js/test/amd-beautify-tests.js
nodejs-js-beautify.noarch: E: script-without-shebang /usr/lib/node_modules/js-beautify/js/test/node-beautify-tests.js

Also, wrong interpreter errors, but apparently the guidelines on that have not yet passed;

nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/lib/cli.js /usr/bin/env node
nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/css-beautify.js /usr/bin/env node
nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/js-beautify.js /usr/bin/env node
nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/html-beautify.js /usr/bin/env node
nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/test/shell-smoke-test.sh /usr/bin/env bash
Comment 4 Package Review 2020-07-10 00:55:04 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 5 Package Review 2020-11-13 00:46:43 UTC 
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.
Note You need to log in before you can comment on or make changes to this bug.