Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1364631 - Review Request: nodejs-glob-stream - A wrapper around node-glob to make it streamy
Summary: Review Request: nodejs-glob-stream - A wrapper around node-glob to make it st...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Depends On: 1364628 1364629 1364630 1443631 1494873 1494874
Blocks: FE-DEADREVIEW nodejs-reviews Node-RED
TreeView+ depends on / blocked
Reported: 2016-08-06 07:32 UTC by Jared Smith
Modified: 2021-06-24 00:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-06-24 00:45:26 UTC
Type: ---

Attachments (Terms of Use)

Description Jared Smith 2016-08-06 07:32:06 UTC
Spec URL:
Description: A wrapper around node-glob to make it streamy
Fedora Account System Username: jsmith

Comment 1 Piotr Popieluch 2017-02-20 22:33:36 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "ISC", "Unknown or generated". 9 files have unknown license.
     Detailed output of licensecheck in /home/piotr/rpmbuild/1364649
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: nodejs-foreground-child-1.5.3-1.fc26.noarch.rpm
nodejs-foreground-child.noarch: W: only-non-binary-in-usr-lib
nodejs-foreground-child.noarch: W: dangling-symlink /usr/lib/node_modules/foreground-child/node_modules/cross-spawn /usr/lib/node_modules/cross-spawn
nodejs-foreground-child.noarch: W: dangling-symlink /usr/lib/node_modules/foreground-child/node_modules/signal-exit /usr/lib/node_modules/signal-exit
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
nodejs-foreground-child.noarch: W: only-non-binary-in-usr-lib
nodejs-foreground-child.noarch: W: dangling-symlink /usr/lib/node_modules/foreground-child/node_modules/cross-spawn /usr/lib/node_modules/cross-spawn
nodejs-foreground-child.noarch: W: dangling-symlink /usr/lib/node_modules/foreground-child/node_modules/signal-exit /usr/lib/node_modules/signal-exit
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

nodejs-foreground-child (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 70a0a0c7be8a8a09dabcc48541844cacbeed063d53a99533f3a6a0d310628607
  CHECKSUM(SHA256) upstream package : 70a0a0c7be8a8a09dabcc48541844cacbeed063d53a99533f3a6a0d310628607

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1364649
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Comment 2 Piotr Popieluch 2017-02-20 22:36:10 UTC
You have to add the check:

%{__nodejs} -e 'require("./")'

Package also needs an update to the latest version.

Other than that seems fine

Comment 3 Robert-André Mauchin 🐧 2017-09-23 09:46:50 UTC
DEBUG  No matching package to install: 'npm(is-negated-glob)'
DEBUG  No matching package to install: 'npm(micromatch)'
DEBUG  No matching package to install: 'npm(pumpify)'
DEBUG  No matching package to install: 'npm(remove-trailing-separator)'

Comment 4 Jared Smith 2017-09-23 22:54:59 UTC
npm(is-negated-glob) is now in Rawhide.

Comment 5 Mattia Verga 2020-05-24 07:22:55 UTC
Removing dependency on old review request of nodejs-micromatch to not list this review as "dependency-rejected" in Fedora-Review.

Comment 6 Package Review 2021-05-25 00:45:15 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2021-06-24 00:45:26 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per
we consider this ticket as DEADREVIEW and proceed to close it.

Note You need to log in before you can comment on or make changes to this bug.