Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1367115 - Review Request: valadoc - Documentation tool for the vala project
Summary: Review Request: valadoc - Documentation tool for the vala project
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 988667 (view as bug list)
Depends On: 988667
Blocks: FE-NEEDSPONSOR plank 1321473
TreeView+ depends on / blocked
 
Reported: 2016-08-15 14:57 UTC by Gergely Polonkai
Modified: 2020-07-06 07:59 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 988667
Environment:
Last Closed: 2020-07-06 07:59:33 UTC
Type: ---
Embargoed:
ppisar: fedora-review?

Attachments (Terms of Use)
log from failed build in fedora-rawhide-x86_64 mock (64.30 KB, text/plain)
2016-08-17 18:53 UTC, Zbigniew Jędrzejewski-Szmek 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 703688 0 Normal RESOLVED valadoc does not compile against GraphViz 2.30 (shipped in Fedora 19) 2020-07-06 07:58:20 UTC
Launchpad 933000 0 None None None 2016-08-15 14:57:05 UTC

Description Gergely Polonkai 2016-08-15 14:57:06 UTC 
+++ This bug was initially created as a clone of Bug #988667 +++


Spec URL: https://gergelypolonkai.fedorapeople.org/valadoc/valadoc.spec
SRPM URL: https://gergelypolonkai.fedorapeople.org/valadoc/valadoc-0.30-1.fc23.src.rpm
Description: Valadoc is a documentation generator for generating API documentation from Vala source code based on libvala.
Fedora Account System Username: gergelypolonkai
Comment 1 Gergely Polonkai 2016-08-15 14:58:40 UTC 
*** Bug 988667 has been marked as a duplicate of this bug. ***
Comment 2 Zbigniew Jędrzejewski-Szmek 2016-08-17 18:53:48 UTC 
Created attachment 1191731 [details]
log from failed build in fedora-rawhide-x86_64 mock

I tried to build the updated package, but it fails because /builddir/build/BUILDROOT/valadoc-0.30-1.fc26.x86_64/usr/lib64/valadoc/drivers/ does not exist. First it fails in %install in find (because the directory does not exists). If I comment that out, it fails in %files:
RPM build errors:
    File not found: /builddir/build/BUILDROOT/valadoc-0.30-1.fc26.x86_64/usr/lib64/valadoc/drivers/0.30.x/libdriver.so

Full build log attached.
Comment 3 Gergely Polonkai 2016-08-17 20:18:45 UTC 
It's a bit strange, as the files are the same as in the old ticket… I will take a look into it and get back with the results.

Also, should I build on Fedora 24 now it is out? The old SRPM was built on F23.
Comment 4 Zbigniew Jędrzejewski-Szmek 2016-08-17 20:51:51 UTC 
The SRPM doesn't need to be rebuilt: the result is (except in some special cases) the same, no matter what the build host.

The binary RPMs should be built on rawhide (in mock, see https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Mock_and_Koji).
Comment 5 Gergely Polonkai 2016-08-17 21:00:15 UTC 
That's exactly the strange part, I had successful mock and koji builds. Still, I'm already looking into it, I hope I can provide a working package soon.
Comment 6 Zbigniew Jędrzejewski-Szmek 2016-08-18 16:39:14 UTC 
It seems to be a vala version problem.

On F23:
checking for valac... /usr/bin/valac
checking whether /usr/bin/valac is at least version 0.15.1... yes
checking for LIBGVC... yes
checking for GLIB... yes
checking for GMODULE... yes
checking for LIBGEE... yes
checking for CGRAPH... yes
checking for LIBVALA_0_30_X... yes
checking for LIBVALA_0_28_X... no
checking for LIBVALA_0_26_X... no
checking for LIBVALA_0_24_X... no
checking for LIBVALA_0_22_X... no
checking for LIBVALA_0_20_X... no
checking for LIBVALA_0_18_X... no
checking for LIBVALA_0_16_X... no

On F24+:
checking whether /usr/bin/valac is at least version 0.15.1... yes
checking for LIBGVC... yes
checking for GLIB... yes
checking for GMODULE... yes
checking for LIBGEE... yes
checking for CGRAPH... yes
checking for LIBVALA_0_30_X... no
checking for LIBVALA_0_28_X... no
checking for LIBVALA_0_26_X... no
checking for LIBVALA_0_24_X... no
checking for LIBVALA_0_22_X... no
checking for LIBVALA_0_20_X... no
checking for LIBVALA_0_18_X... no
checking for LIBVALA_0_16_X... no

And indeed, F24 has vala-0.32.1-1.fc24.x86_64.
Comment 7 Gergely Polonkai 2016-08-18 16:48:18 UTC 
Yes, upstream has been already upgraded to 0.32, and as F24 already has Vala 0.32, maybe I should also upgrade this package (as valadoc follows vala's version numbers, obviously)
Comment 8 Zbigniew Jędrzejewski-Szmek 2016-08-23 05:14:54 UTC 
Yep, looks like an upgrade is needed. Probably some recent git snapshot would be good.
Comment 9 Feng Yu 2016-10-07 18:59:40 UTC 
Supprised to find valadoc is not in the Fedora repo yet. Any progress on this?
Comment 10 Gergely Polonkai 2020-07-06 07:59:33 UTC 
It seems valadoc is already present in F32.
Note You need to log in before you can comment on or make changes to this bug.