Hello Dominiko.

I've worked on tests for this package and I found the solution:
- You need to add python-nose to BR
- You need to extend PYTHONPATH environment variable before you run nosetests command, because tests need module installed in %buildroot/%python2_sitearch.

But this is not all. I've found one problematic test which gets stuck on x86_64 and ARMv7. On i686 all 30 tests pass correctly, but on other architectures this test needs to be skipped. I don't know why so I opened upstream issue [0] and skip this test in specfile [1] for specified architectures.

[0] https://github.com/haypo/faulthandler/issues/25
[1] https://lbalhar.fedorapeople.org/python2-faulthandler.spec

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15351883

Please, look at this specfile, check it and actualize your one with SRPM.

Then we can continue with review :)

It should be up-to-date, now. :)

Spec URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler.spec
SRPM URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler-2.4-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15425733

* Missing BuildRequires: python2-setuptools
* python-nose -> python2-nose

(In reply to Igor Gnatenko from comment #3)
> * Missing BuildRequires: python2-setuptools
> * python-nose -> python2-nose

Thanks, fixed.


Spec URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler.spec
SRPM URL: https://dkrejci.fedorapeople.org/python2-faulthandler/python2-faulthandler-2.4-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15425839

Everything looks good to me.

Package APPROVED

Review output:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated". 9 files have unknown
     license. Detailed output of licensecheck in
     /home/lbalhar/Review/1369374-python2-faulthandler/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -faulthandler-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-faulthandler-2.4-1.fc26.x86_64.rpm
          python2-faulthandler-debuginfo-2.4-1.fc26.x86_64.rpm
          python2-faulthandler-2.4-1.fc26.src.rpm
python2-faulthandler.x86_64: W: spelling-error Summary(en_US) traceback -> trace back, trace-back, racetrack
python2-faulthandler.x86_64: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack
python2-faulthandler.x86_64: W: spelling-error %description -l en_US sigaltstack -> smokestack
python2-faulthandler.src: W: spelling-error Summary(en_US) traceback -> trace back, trace-back, racetrack
python2-faulthandler.src: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack
python2-faulthandler.src: W: spelling-error %description -l en_US sigaltstack -> smokestack
3 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: python2-faulthandler-debuginfo-2.4-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
python2-faulthandler.x86_64: W: spelling-error Summary(en_US) traceback -> trace back, trace-back, racetrack
python2-faulthandler.x86_64: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack
python2-faulthandler.x86_64: W: spelling-error %description -l en_US sigaltstack -> smokestack
2 packages and 0 specfiles checked; 0 errors, 3 warnings.



Requires
--------
python2-faulthandler (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python2-faulthandler-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
python2-faulthandler:
    python2-faulthandler
    python2-faulthandler(x86-64)
    python2.7dist(faulthandler)
    python2dist(faulthandler)

python2-faulthandler-debuginfo:
    python2-faulthandler-debuginfo
    python2-faulthandler-debuginfo(x86-64)



Unversioned so-files
--------------------
python2-faulthandler: /usr/lib64/python2.7/site-packages/faulthandler.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/f/faulthandler/faulthandler-2.4.tar.gz :
  CHECKSUM(SHA256) this package     : 1de8c43fae6de67a015d934873bba5677d923d320098403b5058e28dafba6219
  CHECKSUM(SHA256) upstream package : 1de8c43fae6de67a015d934873bba5677d923d320098403b5058e28dafba6219

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python2-faulthandler

python2-faulthandler-2.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aba642f93a

python2-faulthandler-2.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cf8254448

python2-faulthandler-2.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0320cb771f

python2-faulthandler-2.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0320cb771f

python2-faulthandler-2.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cf8254448

python2-faulthandler-2.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aba642f93a

python2-faulthandler-2.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

python2-faulthandler-2.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

python2-faulthandler-2.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.