Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1372429 - Review Request: openjdk-orb - A downstream fork of OpenJDK's ORB implementation
Summary: Review Request: openjdk-orb - A downstream fork of OpenJDK's ORB implementation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Taylor
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1181081
TreeView+ depends on / blocked
 
Reported: 2016-09-01 17:00 UTC by gil cattaneo
Modified: 2016-09-09 21:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-09 21:48:40 UTC
Type: ---
Embargoed:
jtfas90: fedora-review+

Attachments (Terms of Use)

Description gil cattaneo 2016-09-01 17:00:00 UTC 
Spec URL: https://gil.fedorapeople.org/openjdk-orb.spec
SRPM URL: https://gil.fedorapeople.org/openjdk-orb-8.0.7-1.fc24.src.rpm
Description: JBoss repackaging of the OpenJDK ORB.
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15464009

Wildfly 10+ dependency
Comment 1 Jason Taylor 2016-09-03 03:03:47 UTC 
Hi gil,

looks like Source0 could be updated to 

https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz
Comment 2 Jason Taylor 2016-09-03 03:46:39 UTC 
I don't see a line installing the pom.xml. According to https://fedorahosted.org/released/javapackages/doc/ it looks like there should be a:

%mvn_artifact pom.xml
Comment 3 gil cattaneo 2016-09-03 15:59:38 UTC 
(In reply to Jason Taylor from comment #2)
> I don't see a line installing the pom.xml. According to
> https://fedorahosted.org/released/javapackages/doc/ it looks like there
> should be a:
> 
> %mvn_artifact pom.xml

This should be done only when is used an ant build style
all artifacts (pom and jar) are installed with %mvn_install
https://fedorahosted.org/released/javapackages/doc/#ant
https://fedorahosted.org/released/javapackages/doc/#maven
the guideline is not update, now, "%dir %{_javadir}/%{name}" is useless
because is already owned
Comment 4 gil cattaneo 2016-09-03 16:02:00 UTC 

(In reply to Jason Taylor from comment #1)
> Hi gil,
> 
> looks like Source0 could be updated to 
> 
> https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz
for me is useless. it should be at the discretion of the packager
Comment 5 Jason Taylor 2016-09-03 18:18:15 UTC 
Looks good then, I see you opened a couple of tickets with upstream regarding the misc licensing fixes.

Must and Should components appear to be satisfied. Package approved.
Comment 6 gil cattaneo 2016-09-03 18:41:31 UTC 
(In reply to Jason Taylor from comment #5)
> Looks good then, I see you opened a couple of tickets with upstream
> regarding the misc licensing fixes.
> 
> Must and Should components appear to be satisfied. Package approved.
Thanks! Please, set Status field as ASSIGNED
Comment 7 gil cattaneo 2016-09-03 18:46:44 UTC 
Thanks for the review!

create new SCM request/s:
https://admin.fedoraproject.org/pkgdb/package/requests/7647
https://admin.fedoraproject.org/pkgdb/package/requests/7648
Comment 8 Gwyn Ciesla 2016-09-04 17:44:09 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/openjdk-orb
Comment 9 Fedora Update System 2016-09-04 18:23:09 UTC 
openjdk-orb-8.0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
Comment 10 Fedora Update System 2016-09-05 19:22:17 UTC 
openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
Comment 11 Fedora Update System 2016-09-09 21:48:38 UTC 
openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.