Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1376407 - Review Request: golang-github-mattn-go-isatty - isatty for golang
Summary: Review Request: golang-github-mattn-go-isatty - isatty for golang
Keywords:
Status: CLOSED DUPLICATE of bug 1430143
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1410385 1412344 (view as bug list)
Depends On:
Blocks: 1348906 1376389 1376412 1376437
TreeView+ depends on / blocked
 
Reported: 2016-09-15 11:34 UTC by Matthias Runge
Modified: 2017-06-14 12:21 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-14 12:20:11 UTC
Type: ---
Embargoed:
cheese: fedora-review?

Attachments (Terms of Use)

Description Matthias Runge 2016-09-15 11:34:27 UTC 
Spec URL: https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-isatty/golang-github-mattn-go-isatty.spec

SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-isatty/golang-github-mattn-go-isatty-0-0.1.git56b76bd.fc24.src.rpm

Description: isatty for golang

Fedora Account System Username: mrunge

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15641289

$ rpmlint golang-github-mattn-go-isatty-0-0.1.git56b76bd.fc24.src.rpm golang-github-mattn-go-isatty-devel-0-0.1.git56b76bd.fc24.noarch.rpm
golang-github-mattn-go-isatty.src: W: summary-not-capitalized C isatty for golang
golang-github-mattn-go-isatty-devel.noarch: W: summary-not-capitalized C isatty for golang
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Comment 1 Matthias Runge 2017-01-12 10:02:07 UTC 
*** Bug 1410385 has been marked as a duplicate of this bug. ***
Comment 2 Matthias Runge 2017-01-12 10:02:52 UTC 
*** Bug 1412344 has been marked as a duplicate of this bug. ***
Comment 3 josef radinger 2017-01-12 14:40:21 UTC 
at the start:
%if 0%{?fedora} || 0%{?rhel} == 6
%global with_devel 1
%global with_bundled 0
%global with_debug 0
%global with_check 1
%global with_unit_test 0
%else
%global with_devel 0
%global with_bundled 0
%global with_debug 0
%global with_check 0
%global with_unit_test 0
%endif

i think this could be:
%if 0%{?fedora} || 0%{?rhel} == 6
%global with_devel 1
%global with_check 1
%else
%global with_devel 0
%global with_check 0
%endif

%global with_unit_test 0
%global with_bundled 0
%global with_debug 0

################################
and the actual version (and git revision) would be:
%global commit          30a891c33c7cde7b02a981314b4228ec99380cca

Version:        0.0.1
Release:        1.git%{shortcommit}%{?dist}

please take the release-number with a grain of salt.
Comment 4 Jan Chaloupka 2017-03-07 12:45:03 UTC 
Matthias, can you regenerate the spec with the latest gofed? There are some minor improvements of the spec file.
Comment 5 Matthias Runge 2017-03-20 13:15:22 UTC 
Jan, sorry to keep you waiting here.

This dropped in my prio list, and I couldn't get gofed working (permission issues, my user is in gofed group)
Comment 6 Matthias Runge 2017-03-20 13:16:16 UTC 
I'm happy to close this here in favor of any other review request.
Comment 7 Jan Chaloupka 2017-06-14 12:20:11 UTC 
Closed in favor of https://bugzilla.redhat.com/show_bug.cgi?id=1430143
Comment 8 Jan Chaloupka 2017-06-14 12:21:20 UTC 

*** This bug has been marked as a duplicate of bug 1430143 ***
Note You need to log in before you can comment on or make changes to this bug.