1376511 – Review Request: nexus - NeXus scientific data file format

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1376511 - Review Request: nexus - NeXus scientific data file format

Summary: Review Request: nexus - NeXus scientific data file format

Keywords:
Status:	CLOSED RAWHIDE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Andy Mender
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	FE-NEEDSPONSOR
TreeView+	depends on / blocked

Reported:	2016-09-15 15:55 UTC by Stuart Campbell
Modified:	2020-08-15 01:51 UTC (History)
CC List:	5 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2020-08-15 01:51:05 UTC
Type:	Bug
Embargoed:
Dependent Products:
Flags:	andymenderunix: fedora-review+

Attachments	(Terms of Use)

Description Stuart Campbell 2016-09-15 15:55:50 UTC

SPEC URL: https://github.com/stuartcampbell/rpm-packages/blob/master/nexus/nexus.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sic/science/fedora-rawhide-x86_64/00453405-nexus/nexus-4.4.3-2.fc26.src.rpm


Description: NeXus scientific data file format - 
 NeXus is a common data format for neutron, x-ray, and muon science. It
 is being developed as an international standard by scientists and
 programmers representing major scientific facilities in Europe, Asia,
 Australia, and North America in order to facilitate greater cooperation
 in the analysis and visualization of neutron, x-ray, and muon data. 

Fedora Account System Username: sic

This is my first packages and so I will need a sponsor.  Thank you.
(Well I did submit another package but that hasn't been approved - https://bugzilla.redhat.com/show_bug.cgi?id=1268380)

Comment 1 Stuart Campbell 2016-09-16 12:14:33 UTC

Link to scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15644519

Comment 2 Stuart Campbell 2016-09-16 15:15:30 UTC

Updated SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sic/science/fedora-rawhide-x86_64/00453425-nexus/nexus-4.4.3-2.fc26.src.rpm

Comment 3 Stuart Campbell 2016-10-10 21:43:48 UTC

SPEC URL: https://github.com/stuartcampbell/rpm-packages/blob/master/nexus/nexus.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sic/science/fedora-rawhide-x86_64/00453425-nexus/nexus-4.4.3-2.fc26.src.rpm

Comment 4 Michael Schwendt 2016-10-20 00:28:36 UTC

Drive-by comments. Not easy to review, not a full review. Needs some more work:


> Name:           nexus
> Summary:        NeXus scientific data file format

This %summary could be improved, because so far it is for insiders only and doesn't give a hint what is included in this package. Judging on the %files section contents, this is a library-only package. No program, not tools, and the %summary could mention that. Such as:

  Summary: Library for handling NeXus scientific data files

It's written in C++ and offers shared library APIs for C, C++ and Fortran it seems. Offering all of them in a single package could be drawback because of what is pulled in via implicit dependencies.

Also visit
  https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
and:
  https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries


> License:        LGPL

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Further, the -tools subpackage contains a GPLv2 license text as one of the files in a %doc folder. This needs to be reflected in the "License" tag of that package, and the %license macro ought to be used.

There is another "LICENSE" file included. Consider pointing the fedora-review tool at this bugzilla ticket, since it automates many checks related to licensing.


> Requires:       libgfortran
> Requires:       hdf5
> Requires:       hdf
> Requires:       mxml

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %package        devel
> Summary:        Development files for %{name}
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %package        tools
> Requires:       %{name} = %{version}-%{release}
> Requires:       libxml2
> Requires:       readline

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %install
> rm -rf $RPM_BUILD_ROOT
> %make_install

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


> %files
> %doc %{_datadir}/doc/NeXus/README.doc
> %{_libdir}/libNeXus*
> %{_libdir}/nexus/

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Particularly
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories
since directory /usr/share/doc/NeXus/ would not be included. Similar problem for the -tools subpackage.

Comment 5 Stuart Campbell 2016-10-21 11:50:44 UTC

I've updated with in response to the comments.

SPEC URL: https://sic.fedorapeople.org/nexus/nexus.spec

SRPM URL: https://sic.fedorapeople.org/nexus/nexus-4.4.3-2.fc26.src.rpm

Comment 6 Jared Wallace 2016-11-12 00:18:46 UTC

(This is an unofficial review)

I'll throw some notes out first, but do also review the automated tool output below, as it identified a large quantity of issues as well.

1) You can remove the line "rm -rf $RPM_BUILD_ROOT" from %install

2) You've got a small ton of rpmlint errors that will either need fixing or explaining (ignore spelling issues unless it really is mispelled)

3) If you have questions about any of the issues listed below, let me know and I'll try to help you solve them.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/doc/NeXus/README.doc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: nexus. Illegal package name: nexus. Does not
  provide -static: nexus.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in nexus
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2) (with incorrect FSF address)", "*No copyright* GPL
     (v2)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL (v2 or
     later) (with incorrect FSF address)", "GPL (v2 or later) (with
     incorrect FSF address)", "*No copyright* LGPL (v2 or later) (with
     incorrect FSF address)", "GPL (v2)". 185 files have unknown license.
     Detailed output of licensecheck in /tmp/pkg-
     review/nexus/nexus/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/pkgconfig(pkgconfig), /usr/share/man/man1(filesystem)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 13 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nexus-
     debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: nexus-4.4.3-2.fc24.x86_64.rpm
          nexus-devel-4.4.3-2.fc24.x86_64.rpm
          nexus-tools-4.4.3-2.fc24.x86_64.rpm
          nexus-debuginfo-4.4.3-2.fc24.x86_64.rpm
          nexus-4.4.3-2.fc24.src.rpm
nexus.x86_64: E: explicit-lib-dependency libgfortran
nexus.x86_64: W: name-repeated-in-summary C NeXus
nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus77.so.1.0.0 exit.5
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus.so.1.0.0 exit.5
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus90.so.1.0.0 exit.5
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXusCPP.so.1.0.0 exit.5
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus77.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus77.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus77.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus90.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus90.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus90.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXusCPP.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXusCPP.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus77.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus90.so
nexus-devel.x86_64: W: only-non-binary-in-usr-lib
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
nexus-tools.x86_64: E: explicit-lib-dependency libxml2
nexus-tools.x86_64: W: summary-ended-with-dot C Applications for reading and writing NeXus files.
nexus-tools.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
nexus-tools.x86_64: W: no-manual-page-for-binary nxingest
nexus-tools.x86_64: W: no-manual-page-for-binary nxtraverse
nexus-tools.x86_64: W: no-manual-page-for-binary nxtranslate
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c
nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h
nexus.src: W: name-repeated-in-summary C NeXus
nexus.src: W: spelling-error %description -l en_US muon -> mun, moon, mu on
5 packages and 0 specfiles checked; 30 errors, 23 warnings.




Rpmlint (debuginfo)
-------------------
Checking: nexus-debuginfo-4.4.3-2.fc24.x86_64.rpm
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c
nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h
1 packages and 0 specfiles checked; 17 errors, 1 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nexus.x86_64: E: explicit-lib-dependency libgfortran
nexus.x86_64: W: name-repeated-in-summary C NeXus
nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libmxml.so.1
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libhdf5_cpp.so.11
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libhdf5.so.10
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libdl.so.2
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libm.so.6
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXusCPP.so.1.0.0 exit.5
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libmxml.so.1
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libhdf5_cpp.so.11
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libhdf5.so.10
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libdl.so.2
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libm.so.6
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libgcc_s.so.1
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libquadmath.so.0
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus90.so.1.0.0 exit.5
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libhdf5_cpp.so.11
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libdl.so.2
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libm.so.6
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus.so.1.0.0 exit.5
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libmxml.so.1
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libhdf5_cpp.so.11
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libhdf5.so.10
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libdl.so.2
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libm.so.6
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libgcc_s.so.1
nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libquadmath.so.0
nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus77.so.1.0.0 exit.5
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXusCPP.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXusCPP.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus90.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus90.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus77.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus90.a
nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus77.so.1.0.0
nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus77.so.1.0.0
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus90.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus77.so
nexus-tools.x86_64: E: explicit-lib-dependency libxml2
nexus-tools.x86_64: W: summary-ended-with-dot C Applications for reading and writing NeXus files.
nexus-tools.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
nexus-tools.x86_64: W: no-manual-page-for-binary nxingest
nexus-tools.x86_64: W: no-manual-page-for-binary nxtranslate
nexus-tools.x86_64: W: no-manual-page-for-binary nxtraverse
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h
nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h
nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90
nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c
nexus-devel.x86_64: W: only-non-binary-in-usr-lib
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
4 packages and 0 specfiles checked; 30 errors, 43 warnings.



Requires
--------
nexus (rpmlib, GLIBC filtered):
    hdf
    hdf5
    libNeXus.so.1()(64bit)
    libNeXus77.so.1()(64bit)
    libNeXus90.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgfortran
    libgfortran.so.3()(64bit)
    libgfortran.so.3(GFORTRAN_1.0)(64bit)
    libgfortran.so.3(GFORTRAN_1.1)(64bit)
    libgfortran.so.3(GFORTRAN_1.4)(64bit)
    libhdf5.so.10()(64bit)
    libhdf5_cpp.so.11()(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libm.so.6()(64bit)
    libmxml.so.1()(64bit)
    libpthread.so.0()(64bit)
    libquadmath.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    mxml
    rtld(GNU_HASH)

nexus-tools (rpmlib, GLIBC filtered):
    libNeXus.so.1()(64bit)
    libNeXus90.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgfortran.so.3()(64bit)
    libgfortran.so.3(GFORTRAN_1.0)(64bit)
    libgfortran.so.3(GFORTRAN_1.4)(64bit)
    libhdf5.so.10()(64bit)
    libhdf5_cpp.so.11()(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libm.so.6()(64bit)
    libmxml.so.1()(64bit)
    libpthread.so.0()(64bit)
    libquadmath.so.0()(64bit)
    libreadline.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxml2
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libz.so.1()(64bit)
    nexus(x86-64)
    readline
    rtld(GNU_HASH)

nexus-debuginfo (rpmlib, GLIBC filtered):

nexus-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    hdf-devel
    hdf5-devel
    mxml-devel
    nexus(x86-64)
    pkgconfig(nexus)



Provides
--------
nexus:
    libNeXus.so.1()(64bit)
    libNeXus77.so.1()(64bit)
    libNeXus90.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    nexus
    nexus(x86-64)

nexus-tools:
    nexus-tools
    nexus-tools(x86-64)

nexus-debuginfo:
    nexus-debuginfo
    nexus-debuginfo(x86-64)

nexus-devel:
    nexus-devel
    nexus-devel(x86-64)
    pkgconfig(nexus)
    pkgconfig(nexus-cpp)
    pkgconfig(nexus-f77)



Unversioned so-files
--------------------
nexus: /usr/lib64/libNeXus.so
nexus: /usr/lib64/libNeXus77.so
nexus: /usr/lib64/libNeXus90.so
nexus: /usr/lib64/libNeXusCPP.so

Source checksums
----------------
https://github.com/nexusformat/code/archive/v4.4.3.tar.gz :
  CHECKSUM(SHA256) this package     : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533
  CHECKSUM(SHA256) upstream package : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -rn nexus-4.4.3-2.fc26.src.rpm
Buildroot used: fedora-24-x86_64

Comment 7 Package Review 2020-07-10 00:55:12 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 8 Stuart Campbell 2020-07-11 15:44:12 UTC

I will revisit and update the request shortly.

Comment 9 Andy Mender 2020-07-26 10:16:39 UTC

Stuart, any updates on this?

Comment 10 Petr Pisar 2020-07-27 13:11:55 UTC

Comment 11 Stuart Campbell 2020-08-02 04:34:10 UTC

Spec URL: https://sic.fedorapeople.org/nexus/nexus.spec
SRPM URL: https://sic.fedorapeople.org/nexus/nexus-4.4.3-3.fc32.src.rpm
Description: NeXus is a common data format for neutron, x-ray, and muon science. This
package provides tools and libraries for accessing these files.  The on disk
representation is based upon either HDF4, HDF5 or XML
Fedora Account System Username: sic

Comment 12 Andy Mender 2020-08-02 09:11:35 UTC

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=48423183

> License:        LGPLv2+
> URL:            http://www.nexusformat.org/
> Source0:        https://github.com/nexusformat/code/archive/v4.4.3.tar.gz

- Use the %{version} macro in the Source0 tag.
- Either use an alias for the archive or try this url in your Source0 field: https://github.com/nexusformat/code/archive/v4.4.3/code-v4.4.3.tar.gz
  With macros it would look like this:
  https://github.com/nexusformat/code/archive/v%{version}/code-v%{version}.tar.gz

> BuildRequires:  hdf5-devel
> BuildRequires:  hdf-devel
> BuildRequires:  make
> BuildRequires:  mxml-devel

Check whether it's possible to replace the various -devel package BuildRequires with "pkgconfig(foo)" like mentioned here: https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
Inspect subpackages as well.

> %files devel
> %{_includedir}/nexus/
> %{_libdir}/pkgconfig/

- Does the cmake build generate cmake files? If so, these should also be included in the -devel subpackage. They usually sit in a dir like "%{_libdir}/cmake/%{name}/"
- The pkgconfig line should be more specific, otherwise you're covering the entire pkgconfig dir.

> %files tools
> %{_bindir}/nxbrowse
> %{_bindir}/nxconvert
> %{_bindir}/nxdir
> %{_bindir}/nxsummary
> %{_bindir}/nxtranslate
> %{_bindir}/nxtraverse
> %doc %{_datadir}/doc/NeXus/programs/
> %{_mandir}/man1/

I would list the manpages explicitly. You can use wildcards, though.

> %post -p /sbin/ldconfig

> %postun -p /sbin/ldconfig

Calling ldconfig explicitly is no longer needed and these calls should be removed.

Full review matrix below:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- ldconfig not called in %post and %postun for Fedora 28 and later.
  Note: /sbin/ldconfig called in nexus
  See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
  Review: see earlier comment.
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages
  Review: I think this is related to the "%{_libdir}/libNeXus*" line in the
  main package. SO files in main packages should have a version number. 
  Check above guidelines for reference.
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text
  Review: LICENSE file not included in the package, though available?
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: nexus. Illegal package name: nexus. Does not
  provide -static: nexus.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#packaging-static-libraries
  Review: see the below rpmlint reports.
  

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License (v2
     or later)", "*No copyright* GNU Lesser General Public License", "GPL
     (v2 or later) (with incorrect FSF address)", "Expat License", "*No
     copyright* Expat License", "zlib/libpng license", "*No copyright* GNU
     Lesser General Public License (v2 or later)", "GPL (v2) (with
     incorrect FSF address)", "GNU Lesser General Public License (v3 or
     later)", "GNU Lesser General Public License", "GPL (v2)", "*No
     copyright* GPL (v2)". 347 files have unknown license. Detailed output
     of licensecheck in
     /home/amender/rpmbuild/SPECS/nexus/nexus/licensecheck.txt
     Review: There is a single file under LGPLv3+
     code-4.4.3/applications/c-nxvalidate/NXxrotflat.nxdl.xml: GNU Lesser General Public License (v3 or later)
[!]: License file installed when any subpackage combination is installed.
     Review: no license file provided.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
     Review: see rpmlint report.
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
     Review: see earlier comments regarding owning directories.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 9 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
     Review: see earlier comments about owned directories.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
     Review: license file available, but not included.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
     Review: some patches require extra links if available.
[-]: Scriptlets must be sane, if used.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: nexus-4.4.3-3.fc33.x86_64.rpm
          nexus-devel-4.4.3-3.fc33.x86_64.rpm
          nexus-tools-4.4.3-3.fc33.x86_64.rpm
          nexus-debuginfo-4.4.3-3.fc33.x86_64.rpm
          nexus-debugsource-4.4.3-3.fc33.x86_64.rpm
          nexus-4.4.3-3.fc33.src.rpm
nexus.x86_64: W: name-repeated-in-summary C NeXus
nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h
nexus-tools.x86_64: E: explicit-lib-dependency libxml2
nexus-tools.x86_64: W: summary-ended-with-dot C Applications for reading and writing NeXus files.
nexus-tools.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
nexus-tools.x86_64: W: no-manual-page-for-binary nxtranslate
nexus-tools.x86_64: W: no-manual-page-for-binary nxtraverse
nexus.src: W: name-repeated-in-summary C NeXus
nexus.src: W: spelling-error %description -l en_US muon -> mun, moon, mu on
nexus.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 22)
nexus.src: E: specfile-error warning: bogus date in %changelog: Sat Aug 02 2020 Stuart Campbell <sic> - 4.4.3-3
6 packages and 0 specfiles checked; 5 errors, 13 warnings.




Rpmlint (debuginfo)
-------------------
Checking: nexus-debuginfo-4.4.3-3.fc33.x86_64.rpm
          nexus-tools-debuginfo-4.4.3-3.fc33.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
(none): E: no installed packages by name nexus-tools
(none): E: no installed packages by name nexus-debuginfo
(none): E: no installed packages by name nexus-devel
(none): E: no installed packages by name nexus
(none): E: no installed packages by name nexus-debugsource
(none): E: no installed packages by name nexus-tools-debuginfo
0 packages and 0 specfiles checked; 0 errors, 0 warnings.



Unversioned so-files
--------------------
nexus: /usr/lib64/libNeXus.so
nexus: /usr/lib64/libNeXusCPP.so

Source checksums
----------------
https://github.com/nexusformat/code/archive/v4.4.3.tar.gz :
  CHECKSUM(SHA256) this package     : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533
  CHECKSUM(SHA256) upstream package : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533


Requires
--------
nexus (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    hdf
    hdf5
    libNeXus.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    libc.so.6()(64bit)
    libdf.so.0()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhdf5.so.103()(64bit)
    libmfhdf.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    mxml
    rtld(GNU_HASH)

nexus-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    hdf-devel
    hdf5-devel
    nexus(x86-64)
    pkgconfig(nexus)

nexus-tools (rpmlib, GLIBC filtered):
    libNeXus.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libreadline.so.8()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxml2
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    nexus(x86-64)
    readline
    rtld(GNU_HASH)

nexus-debuginfo (rpmlib, GLIBC filtered):

nexus-debugsource (rpmlib, GLIBC filtered):



Provides
--------
nexus:
    libNeXus.so.1()(64bit)
    libNeXusCPP.so.1()(64bit)
    nexus
    nexus(x86-64)

nexus-devel:
    nexus-devel
    nexus-devel(x86-64)
    pkgconfig(nexus)
    pkgconfig(nexus-cpp)
    pkgconfig(nexus-f77)

nexus-tools:
    nexus-tools
    nexus-tools(x86-64)

nexus-debuginfo:
    debuginfo(build-id)
    nexus-debuginfo
    nexus-debuginfo(x86-64)

nexus-debugsource:
    nexus-debugsource
    nexus-debugsource(x86-64)

Comment 13 Stuart Campbell 2020-08-02 20:03:09 UTC

Thank you very much for the review and helpful comments. 

- I have used the %{version} macro
- Changed the BuildRequires to use pkgconfig where I can (HDF4/5 do not seem to have .pc files)
- None of the CMake generated files are useful to ship - this can be changed upstream and then should be included in the package.
- Added the license file and (hopefully) made it clear for the nxdir tool being MIT licensed. 
- removed ldconfig lines.

I think there are changes that can be made upstream to clean up the package longer term, which I will try and get included in the next upstream patch release.

Comment 14 Stuart Campbell 2020-08-02 20:04:05 UTC

Spec URL: https://sic.fedorapeople.org/nexus/nexus.spec
SRPM URL: https://sic.fedorapeople.org/nexus/nexus-4.4.3-4.fc32.src.rpm
Description: NeXus is a common data format for neutron, x-ray, and muon science. This
package provides tools and libraries for accessing these files.  The on disk
representation is based upon either HDF4, HDF5 or XML
Fedora Account System Username: sic

Comment 15 Andy Mender 2020-08-02 20:52:35 UTC

> - None of the CMake generated files are useful to ship - this can be changed upstream and then should be included in the package.

Sounds good.

> I think there are changes that can be made upstream to clean up the package longer term, which I will try and get included in the next upstream patch release.

Fingers crossed!

A couple of remaining points highlighted by rpmlint:
Rpmlint
-------
Checking: nexus-4.4.3-4.fc33.x86_64.rpm
          nexus-devel-4.4.3-4.fc33.x86_64.rpm
          nexus-tools-4.4.3-4.fc33.x86_64.rpm
          nexus-debuginfo-4.4.3-4.fc33.x86_64.rpm
          nexus-debugsource-4.4.3-4.fc33.x86_64.rpm
          nexus-4.4.3-4.fc33.src.rpm
nexus.x86_64: W: name-repeated-in-summary C NeXus
nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a
nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so

The *.a static libs should go into a separate nexus-static package, but preferably be removed from the buildroot entirely. Unversioned *.so files should go into the -devel package. I think the problem in the spec file is here (highlighted with <<):
%files
%license COPYING
%doc %{_datadir}/doc/NeXus/README.doc
%{_libdir}/libNeXus* << 

I inspected the final RPM and it does contain "versioned" SO files:
- libNeXus.so.1
- libNeXus.so.1.0.0
- libNeXusCPP.so.1
- libNeXusCPP.so.1.0.0
These can be captured in the following way:
%{_libdir}/libNeXus.so.1*
%{_libdir}/libNeXusCPP.so.1*

However, their versions don't match the package version sadly.

Your devel package should then explicitly catch the unversioned SO files:
%{_libdir}/libNeXus.so
%{_libdir}/libNeXusCPP.so

More info on devel and static subpackages:
- https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries

nexus.x86_64: E: incorrect-fsf-address /usr/share/licenses/nexus/COPYING
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h

Not quite sure why rpmlint listed these, but here's the doc on the error: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

nexus-tools.x86_64: E: explicit-lib-dependency libxml2

Not sure whether this is an actual issue. A quick google search shows that lib* library discovery should be left to rpm itself and not be explicitly listed in the SPEC file. Could you try building without it to see whether it still works?

[...]
nexus.src: W: patch-not-applied Patch3: nexus-add-license.patch
6 packages and 0 specfiles checked; 4 errors, 14 warnings.

I missed this one last time. Should this patch be applied or removed? I see the main package already has a COPYING file listed with %license.

Comment 16 Stuart Campbell 2020-08-02 21:38:15 UTC

Thank you again.

For the COPYING file, I wasn't sure if the file had to be 'installed' (hence the patch was to add that to CMake), but it looks like the %license macro picks it up from the source/build. 

I think I've addressed everything, the only warnings I see with rpmlint are now:

nexus.src: W: name-repeated-in-summary C NeXus
nexus.src: W: spelling-error %description -l en_US muon -> mun, moon, mu on

Wasn't sure how bad the first one is, but the second one is a false warning, as muon is spelt correctly.

Comment 17 Stuart Campbell 2020-08-02 21:38:44 UTC

Spec URL: https://sic.fedorapeople.org/nexus/nexus.spec
SRPM URL: https://sic.fedorapeople.org/nexus/nexus-4.4.3-5.fc32.src.rpm
Description: NeXus is a common data format for neutron, x-ray, and muon science. This
package provides tools and libraries for accessing these files.  The on disk
representation is based upon either HDF4, HDF5 or XML
Fedora Account System Username: sic

Comment 18 Andy Mender 2020-08-03 20:46:07 UTC

> For the COPYING file, I wasn't sure if the file had to be 'installed' (hence the patch was to add that to CMake), but it looks like the %license macro picks it up from the source/build.

If it's in the root of the source dir, using %license for license files and %doc for documentation files will add these to the correct directories :).

> Wasn't sure how bad the first one is, but the second one is a false warning, as muon is spelt correctly.

I think the first one is bogus as well. Don't worry about it.

Last things reported by rpmlint:

Rpmlint
-------
[...]
nexus.x86_64: E: incorrect-fsf-address /usr/share/licenses/nexus/COPYING
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h
[...]
6 packages and 0 specfiles checked; 3 errors, 8 warnings.

A rather minor item, but I would add the COPYING file to the -devel package as well:
%files devel
%license COPYING

As for the "incorrect-fsf-address" errors, the guidelines recommend contacting upstream: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
I've personally never seen this before, but it's not a blocking issue either way.

Comment 19 Stuart Campbell 2020-08-03 22:21:56 UTC

Awesome, thank you - I will look into the fsf issue upstream.  I've added the COPYING file into the devel package.

Comment 20 Stuart Campbell 2020-08-03 22:22:24 UTC

Spec URL: https://sic.fedorapeople.org/nexus/nexus.spec
SRPM URL: https://sic.fedorapeople.org/nexus/nexus-4.4.3-6.fc32.src.rpm
Description: NeXus is a common data format for neutron, x-ray, and muon science. This
package provides tools and libraries for accessing these files.  The on disk
representation is based upon either HDF4, HDF5 or XML
Fedora Account System Username: sic

Comment 21 Andy Mender 2020-08-04 18:51:42 UTC

Nice! Package approved!

Comment 22 Gwyn Ciesla 2020-08-10 13:26:26 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nexus

Note You need to log in before you can comment on or make changes to this bug.