Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1377229 - Review Request: golang-github-inconshreveable-log15 - Structured, composable logging for Go
Summary: Review Request: golang-github-inconshreveable-log15 - Structured, composable ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1376412 1377227 1689595
Blocks: 1376389
TreeView+ depends on / blocked
 
Reported: 2016-09-19 09:20 UTC by Matthias Runge
Modified: 2019-03-16 22:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-04 09:33:48 UTC
Type: ---
Embargoed:
zebob.m: fedora-review?

Attachments (Terms of Use)

Description Matthias Runge 2016-09-19 09:20:26 UTC 
Spec URL: https://mrunge.fedorapeople.org/reviews/golang-github-inconshreveable-log15/golang-github-inconshreveable-log15.spec

SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-inconshreveable-log15/golang-github-inconshreveable-log15-0-0.1.gitf1f14b4.fc24.src.rpm

Description: Structured, composable logging for Go

Fedora Account System Username: mrunge

$ rpmlint golang-github-inconshreveable-log15-0-0.1.gitf1f14b4.fc24.src.rpm golang-github-inconshreveable-log15-devel-0-0.1.gitf1f14b4.fc24.noarch.rpm golang-github-inconshreveable-log15-unit-test-devel-0-0.1.gitf1f14b4.fc24.x86_64.rpm
golang-github-inconshreveable-log15.src: W: spelling-error Summary(en_US) composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15.src: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15-devel.noarch: W: spelling-error Summary(en_US) composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15-devel.noarch: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Comment 1 Robert-André Mauchin 🐧 2017-09-18 08:04:21 UTC 
 - Please bump to the latest revision (can't use the last tagged revision since Go 1.8 support was added later):

%global commit          74a0988b5f804e8ce9ff74fca4f16980776dff29

 - Please provide a commitdate for versionning:

%global commitdate      20170623

   And:

Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}

   Then:

* Mon Sep 18 2017 Matthias Runge <mrunge> - 0-0.1.20170623git74a0988


The newest revision depends on golang(github.com/go-stack/stack) which is not yet packaged. Please package the latest tagged version https://github.com/go-stack/stack/releases and I'll review it.
Comment 2 Matthias Runge 2018-09-04 09:33:48 UTC 
Thank you for your review. My scope shifted a bit and I don't have cycles to continue here, unfortunately.
Note You need to log in before you can comment on or make changes to this bug.