Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1380179 - Review Request: webvirtmgr - panel for manage virtual machine
Summary: Review Request: webvirtmgr - panel for manage virtual machine
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: jiri vanek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1432365
Blocks: PYTHON3
TreeView+ depends on / blocked
 
Reported: 2016-09-28 20:58 UTC by Raphael Groner
Modified: 2018-12-19 08:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-26 18:08:37 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Raphael Groner 2016-09-28 20:58:32 UTC 
Spec URL: https://raphgro.fedorapeople.org/review/py/webvirtmgr/webvirtmgr.spec
SRPM URL: https://raphgro.fedorapeople.org/review/py/webvirtmgr/webvirtmgr-4.8.9-2.20160508git.fc24.src.rpm
Description: webvirtmgr panel for manage virtual machine
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15849466
Comment 1 Raphael Groner 2016-09-28 21:00:38 UTC 
Notes:
- There's an issue with current django to make webvirtmgr not work.
https://github.com/retspen/webvirtmgr/issues/624
https://github.com/retspen/webvirtmgr/issues/592
- The package should be ported to Python3. i assume upstream did not port so far.
Comment 2 Raphael Groner 2016-11-05 23:13:11 UTC 
EPEL7 has (still) Django 1.6, so we can provide a package there, at least.
Comment 3 jiri vanek 2016-11-07 09:36:49 UTC 
Hello! I'm wiling to review, however whats the point of bringing it in, if the application do not work in Fedora?

Maybe django1.6-compact package is the way to go in fedora (and keep python2)?

I do not have precedense for epel7 only pkg, although I do not have issues with epel7 pkg only...
Comment 4 Matthias Runge 2016-11-07 10:44:12 UTC 
Hey, I'm currently the django maintainer in Fedora (and EPEL). I'd be trying to get rid of (unmaintained by upstream) Django-1.6 in EPEL7 ASAP. Django releases roughly every 9 months, latest LTS version is Django-1.8. 

That means, you should wait for a new release of webvirtmgr, if possible.
Comment 5 Raphael Groner 2016-11-11 20:41:52 UTC 
I can try to work with upstream on a patch to update webvirtmgr to work with a newer Django.
Comment 6 jiri vanek 2016-11-14 09:58:21 UTC 
Thanx. Please let me know when you feel the review can be continued. I will finish it.
Comment 7 Raphael Groner 2017-09-02 17:28:31 UTC 
(In reply to Matthias Runge from comment #4)
> Hey, I'm currently the django maintainer in Fedora (and EPEL). I'd be trying
> to get rid of (unmaintained by upstream) Django-1.6 in EPEL7 ASAP. Django
> releases roughly every 9 months, latest LTS version is Django-1.8. 
> 
> That means, you should wait for a new release of webvirtmgr, if possible.

"Django 1.6 actually is maintained"!

https://bugzilla.redhat.com/show_bug.cgi?id=1432365#c8
Comment 8 Matthias Runge 2017-09-04 06:40:09 UTC 
Current Django LTS version is Django 1.11

Django 1.6 is maintained by reviewboard upstream.

If you want webvirtmgr in EPEL (and maybe in Fedora), please make sure it works with the compatibility package.
Comment 9 Raphael Groner 2017-10-30 17:50:30 UTC 
As python-django16 is now available at least in epel7, I'm going to continue ASAP with the fixes for this review.
Comment 10 Raphael Groner 2017-11-25 21:45:28 UTC 
Upstream does not intend to support SELinux. Is that a reason to discontinue with the package review?

https://github.com/retspen/webvirtmgr/issues/195
https://github.com/retspen/webvirtmgr/issues/645#issuecomment-339066079
Comment 11 Neal Gompa 2017-11-25 22:19:53 UTC 
(In reply to Raphael Groner from comment #10)
> Upstream does not intend to support SELinux. Is that a reason to discontinue
> with the package review?
> 
> https://github.com/retspen/webvirtmgr/issues/195
> https://github.com/retspen/webvirtmgr/issues/645#issuecomment-339066079

No, it means that if it needs an SELinux policy to work, you should write and contribute one. You can ask for help from the Fedora SELinux team.
Comment 12 Raphael Groner 2017-11-26 18:08:37 UTC 
Essentially, CVE-2015-5144 and CVE-2015-5145 prevent me from continuing with this review request. Sorry for not looking into the release model and security aspects of django even more earlier, thanks for your time to hint me to all the issues.

Though, please feel free to use this as a base for another try when upstream hopefully switch to officially support a more current version of django.

https://github.com/retspen/webvirtmgr/issues/592
Comment 13 Raphael Groner 2018-12-19 08:57:34 UTC 
FTR Future development seems to happen with WebVirtCloud.
https://github.com/retspen/webvirtcloud
https://readthedocs.org/projects/webvirtcloud/
Note You need to log in before you can comment on or make changes to this bug.