1384249 – Review Request: python3-ply - Python Lex-Yacc

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1384249 - Review Request: python3-ply - Python Lex-Yacc

Summary: Review Request: python3-ply - Python Lex-Yacc

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Tim Orling
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2016-10-12 22:55 UTC by Orion Poplawski
Modified:	2016-12-15 03:49 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2016-12-14 19:47:01 UTC
Type:	Bug
Embargoed:
Dependent Products:
Flags:	TicoTimo: fedora-review+

Attachments	(Terms of Use)

Description Orion Poplawski 2016-10-12 22:55:17 UTC

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-ply.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-ply-3.8-1.el7.src.rpm
Description:
PLY is a straightforward lex/yacc implementation. Here is a list of its 
essential features:
* It is implemented entirely in Python.
* It uses LR-parsing which is reasonably efficient and well suited for larger 
  grammars.
* PLY provides most of the standard lex/yacc features including support 
  for empty productions, precedence rules, error recovery, and support
  for ambiguous grammars.
* PLY is straightforward to use and provides very extensive error checking.
* PLY doesn't try to do anything more or less than provide the basic lex/yacc
  functionality. In other words, it's not a large parsing framework or a
  component of some larger system.

  functionality. In other words, it's not a large parsing framework or a
  component of some larger system.


Fedora Account System Username: orion

This is an EPEL only package.

Scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=16067960

Comment 1 Tim Orling 2016-11-08 05:15:15 UTC

Koji build EPEL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=16345664
Koji build EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=16345670

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Latest version is 3.9, provided version is 3.8

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated". 141 files have
     unknown license. Detailed output of licensecheck in
     /home/parallels/1384249-python3-ply/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: python34-ply (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
     => ply 3.9 is latest
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python34-ply-3.8-1.el7.centos.noarch.rpm
          python3-ply-3.8-1.el7.centos.src.rpm
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/cpp.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ctokens.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ctokens.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/cpp.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/lex.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/lex.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ygen.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/yacc.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ygen.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/yacc.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: W: file-not-utf8 /usr/share/doc/python34-ply-3.8/CHANGES
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
=> These are a from a bug in rpmlint: https://lists.opensuse.org/opensuse-bugs/2014-05/msg00374.html
2 packages and 0 specfiles checked; 12 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/cpp.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ctokens.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ctokens.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/cpp.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/lex.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/lex.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ygen.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/yacc.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/ygen.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/yacc.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: W: file-not-utf8 /usr/share/doc/python34-ply-3.8/CHANGES
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-ply.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/ply/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
1 packages and 0 specfiles checked; 12 errors, 1 warnings.



Requires
--------
python34-ply (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python34-ply:
    python34-ply



Source checksums
----------------
http://www.dabeaz.com/ply/ply-3.8.tar.gz :
  CHECKSUM(SHA256) this package     : e7d1bdff026beb159c9942f7a17e102c375638d9478a7ecd4cc0c76afd8de0b8
  CHECKSUM(SHA256) upstream package : e7d1bdff026beb159c9942f7a17e102c375638d9478a7ecd4cc0c76afd8de0b8


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1384249
Buildroot used: epel-7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Orion Poplawski 2016-11-08 18:31:34 UTC

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-ply.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-ply-3.9-1.el7.src.rpm

* Tue Nov 8 2016 Orion Poplawski <orion.com> - 3.9-1
- Update to 3.9

Comment 3 Tim Orling 2016-11-26 19:15:39 UTC

Apologies for taking so long to re-review.

Koji EPEL7 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16638005

Koji EL6 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16638062

[x] Latest version is packaged.

APPROVED

Comment 4 Gwyn Ciesla 2016-11-28 14:28:51 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-ply

Comment 5 Fedora Update System 2016-11-28 16:15:50 UTC

python3-ply-3.9-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1a54effc5e

Comment 6 Fedora Update System 2016-11-28 16:15:59 UTC

python3-ply-3.9-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a8d6434886

Comment 7 Fedora Update System 2016-11-30 05:50:29 UTC

python3-ply-3.9-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a8d6434886

Comment 8 Fedora Update System 2016-11-30 05:51:31 UTC

python3-ply-3.9-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1a54effc5e

Comment 9 Fedora Update System 2016-12-14 19:47:01 UTC

python3-ply-3.9-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-12-14 20:52:27 UTC

python3-ply-3.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-12-15 03:49:58 UTC

python3-ply-3.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.