Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1400939 - python-trezor: Provide a Python 3 subpackage
Summary: python-trezor: Provide a Python 3 subpackage
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-trezor
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jonny Heggheim
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-AVAILABLE
TreeView+ depends on / blocked
 
Reported: 2016-12-02 11:12 UTC by Iryna Shcherbina
Modified: 2018-01-01 12:18 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:11:27 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Iryna Shcherbina 2016-12-02 11:12:18 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's OK to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 25 as well.


If you need more instructions, a guide for porting Python-based RPMs is
available at [2].
If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
[2] http://python-rpm-porting.readthedocs.io/
Comment 1 Fedora End Of Life 2017-02-28 10:42:59 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.
Comment 2 Jan Beran 2017-11-27 15:49:32 UTC 
Hello Jonny,

I created a Pagure PR that provides Python 3 subpackage:

https://src.fedoraproject.org/rpms/python-trezor/pull-request/1

Please, may I ask to review and rebuild?
Comment 3 Jonny Heggheim 2017-11-28 10:28:15 UTC 
(In reply to Jan Beran from comment #2)
> Hello Jonny,
> 
> I created a Pagure PR that provides Python 3 subpackage:
> 
> https://src.fedoraproject.org/rpms/python-trezor/pull-request/1
> 
> Please, may I ask to review and rebuild?

Thanks, I will review your PR today after my day job.
Comment 4 Jan Beran 2017-12-05 10:22:52 UTC 
Note, /usr/bin/trezorctl executable file uses Python 3 and is moved from python2-trezor to python3-trezor subpackage.
Comment 5 Jan Beran 2017-12-20 07:29:03 UTC 
Hi Jonny,

I am just a voluntary contributor in Python 3 support project in Fedora [http://fedora.portingdb.xyz/]. Because I am not Fedora packager, I have no permissions to make any rawhide build. May I ask you to continue with the next steps related to this package also on rawhide and close the bug?

Thank you.

Best regards

Jan
Comment 6 Jonny Heggheim 2017-12-20 11:11:27 UTC 
Thanks, I forgot to build for rawhide.

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23804894
Note You need to log in before you can comment on or make changes to this bug.