Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1406346 - meld: meld-3.17.0-2.fc26 requires both Python 2 and Python 3
Summary: meld: meld-3.17.0-2.fc26 requires both Python 2 and Python 3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: meld
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3
TreeView+ depends on / blocked
 
Reported: 2016-12-20 10:34 UTC by Iryna Shcherbina
Modified: 2016-12-22 10:25 UTC (History)
3 users (show)

Fixed In Version: meld-3.17.0-3.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-22 10:25:46 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Iryna Shcherbina 2016-12-20 10:34:13 UTC 
The meld-3.17.0-2.fc26 RPM has both Python 2 and Python 3 dependencies:

$ rpm -qRp meld-3.17.0-2.fc24.noarch.rpm
...
/usr/bin/python3
dbus-python
pycairo
pygobject3-devel
python(abi) = 3.5
...

This software supports Python 3 [0], and the dependencies are already ported (python3-dbus, python3-cairo, python3-gobject). Is there any reason to keep Python 2 dependencies?

Except in very special circumstances, there is no need for one package
to drag in both Python stacks. There is a section on Requires in the Python RPM Porting Guide [1] which covers this issue.

Please split your package, or remove the stray dependencies.


If anything is unclear, or if you need any kind of assistance, you can
ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy
to help investigating or fixing this issue!

[0] http://meldmerge.org/news.html
[1] http://python-rpm-porting.readthedocs.io/en/latest/applications.html#buildrequires-and-requires
Comment 1 Dominic Hopf 2016-12-20 12:28:14 UTC 
Hi Iryna,

thanks very much for reporting this. There is no specific reason for keeping dependencies to Python 2, seems I've just overlooked something. I've built a new release which adjusts the dependencies you've mentioned:

    https://koji.fedoraproject.org/koji/taskinfo?taskID=16992229

I'd be glad if you'd had a look if that looks better now, obviously my Python packaging know-how doesn't seem that advanced… :-)
Comment 2 Iryna Shcherbina 2016-12-22 10:25:46 UTC 
Hi Dominic,

thank you very much for a prompt response.
The change looks good, closing the bug.
Note You need to log in before you can comment on or make changes to this bug.