Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1413295 - Review Request: nodejs-mv - A fs.rename that works across devices. Same as the unix utility 'mv'
Summary: Review Request: nodejs-mv - A fs.rename that works across devices. Same as th...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews Node-RED 1415439
TreeView+ depends on / blocked
Reported: 2017-01-14 16:04 UTC by Jared Smith
Modified: 2017-03-04 21:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-03-04 21:05:43 UTC
Type: ---
tom: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2017-01-14 16:04:34 UTC
Spec URL:
Description: A fs.rename that works across devices. Same as the unix utility 'mv'
Fedora Account System Username: jsmith

Comment 1 Tom Hughes 2017-02-23 18:39:19 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package installs properly.
  Note: Installation errors (see attachment)

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 9 files have
     unknown license. Detailed output of licensecheck in /home/tom/1413295
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)

Installation errors
INFO: version 1.3.3 starting (python version = 3.5.2)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.3.3
INFO: Mock Version: 1.3.3
Finish: chroot init
INFO: installing package(s): /home/tom/1413295-nodejs-mv/results/nodejs-mv-2.1.1-1.fc26.noarch.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/compton-rawhide-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/tom/1413295-nodejs-mv/results/nodejs-mv-2.1.1-1.fc26.noarch.rpm

Checking: nodejs-mv-2.1.1-1.fc26.noarch.rpm
nodejs-mv.noarch: W: spelling-error Summary(en_US) fs -> sf, gs, fa
nodejs-mv.noarch: W: spelling-error Summary(en_US) unix -> UNIX, Unix, uni
nodejs-mv.noarch: W: spelling-error %description -l en_US fs -> sf, gs, fa
nodejs-mv.noarch: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni
nodejs-mv.noarch: W: only-non-binary-in-usr-lib
nodejs-mv.noarch: W: dangling-symlink /usr/lib/node_modules/mv/node_modules/rimraf /usr/lib/node_modules/rimraf
nodejs-mv.noarch: W: dangling-symlink /usr/lib/node_modules/mv/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-mv.noarch: W: dangling-symlink /usr/lib/node_modules/mv/node_modules/ncp /usr/lib/node_modules/ncp
nodejs-mv.src: W: spelling-error Summary(en_US) fs -> sf, gs, fa
nodejs-mv.src: W: spelling-error Summary(en_US) unix -> UNIX, Unix, uni
nodejs-mv.src: W: spelling-error %description -l en_US fs -> sf, gs, fa
nodejs-mv.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni
2 packages and 0 specfiles checked; 0 errors, 12 warnings.

Diff spec file in url and in SRPM
--- /home/tom/1413295-nodejs-mv/srpm/nodejs-mv.spec	2017-02-23 18:29:08.595311453 +0000
+++ /home/tom/1413295-nodejs-mv/srpm-unpacked/nodejs-mv.spec	2015-11-06 18:30:16.000000000 +0000
@@ -6,5 +6,5 @@
 Name:		nodejs-mv
 Version:	2.1.1
-Release:	2%{?dist}
+Release:	1%{?dist}
 Summary:	A fs.rename that works across devices. Same as the unix utility 'mv'
@@ -36,5 +36,4 @@
 %setup -q -n package
-%nodejs_fixdep rimraf ^2.5
@@ -64,7 +63,4 @@
-* Mon Jan 16 2017 Jared Smith <jsmith> - 2.1.1-2
-- Relax dependency on npm(rimraf)
 * Fri Nov  6 2015 Jared Smith <jsmith> - 2.1.1-1
 - Initial packaging

nodejs-mv (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 684ed634a8679a5583743a996ac67a430f8082b9c3cc76f1f82ae5ccaa9595ab
  CHECKSUM(SHA256) upstream package : 684ed634a8679a5583743a996ac67a430f8082b9c3cc76f1f82ae5ccaa9595ab

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1413295
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Comment 2 Tom Hughes 2017-02-23 18:41:06 UTC
Make sure you use the right spec - there is currently a mismatch with the one on the SRPM which meant the package built by fedora-review wouldn't install.

Other than that it looks good.

Comment 3 Gwyn Ciesla 2017-02-27 13:35:21 UTC
Package request has been approved:

Note You need to log in before you can comment on or make changes to this bug.