Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1423390 - Review Request: prewikka
Summary: Review Request: prewikka
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-17 08:35 UTC by Thomas Andrejak
Modified: 2017-08-12 11:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-12 11:35:13 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 222070 0 medium CLOSED Review Request: prewikka - Prelude IDS Management Console 2022-05-16 11:32:56 UTC

Internal Links: 222070

Description Thomas Andrejak 2017-02-17 08:35:56 UTC 
This is the continuation of #1386938 . This ticket is for prewikka. This is the GUI of Prelude.

Description in spec :
Prewikka is the graphical front-end analysis console for the Prelude SIEM.
Providing numerous features, Prewikka facilitates the work of users and
analysts. It provides alert aggregation and sensor and heartbeat views, and has
user customization and configurable filters. Prewikka also provides access to
external tools such as whois and traceroute.

SPEC : https://fedorapeople.org/~totol/prewikka.spec
SRPM : https://fedorapeople.org/~totol/prewikka-3.1.0-1.fc26.src.rpm
Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=17912549

Thanks for the review

Regards

Thomas
Comment 1 Zbigniew Jędrzejewski-Szmek 2017-02-21 21:17:17 UTC 
fedora-review complains:
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python2.7/site-
     packages/prewikka/locale/de, /usr/lib/python2.7/site-
     packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/fr, /usr/lib/python2.7/site-
     packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/en, /usr/lib/python2.7/site-
     packages/prewikka/locale, /usr/lib/python2.7/site-
     packages/prewikka/locale/es, /usr/lib/python2.7/site-
     packages/prewikka/locale/ru, /usr/lib/python2.7/site-
     packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site-
     packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka, /usr/lib/python2.7/site-
     packages/prewikka/locale/it, /usr/lib/python2.7/site-
     packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-
     packages/prewikka/locale/pl
This should be covered by -f %{name}.lang, looks like this doesn't work for some reason.

I don't think you need to provide the versioned symlinks: they are only used when two versions of an application can be installed that behave *differently* for python2 and python3. Here, if python3 support is added in the future, there will be no difference in behaviour when running under python2 and python3, IIUC.
Comment 2 Thomas Andrejak 2017-02-21 22:53:33 UTC 
New files : 
SPEC : https://fedorapeople.org/~totol/prewikka.spec
SRPM : https://fedorapeople.org/~totol/prewikka-3.1.0-1.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> fedora-review complains:
> [ ]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/lib/python2.7/site-
>      packages/prewikka/locale/de, /usr/lib/python2.7/site-
>      packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/fr, /usr/lib/python2.7/site-
>      packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/en, /usr/lib/python2.7/site-
>      packages/prewikka/locale, /usr/lib/python2.7/site-
>      packages/prewikka/locale/es, /usr/lib/python2.7/site-
>      packages/prewikka/locale/ru, /usr/lib/python2.7/site-
>      packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site-
>      packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka, /usr/lib/python2.7/site-
>      packages/prewikka/locale/it, /usr/lib/python2.7/site-
>      packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-
>      packages/prewikka/locale/pl
> This should be covered by -f %{name}.lang, looks like this doesn't work for
> some reason.

I try another approch, it add a new warning in rpmlint but the SPEC is more clean. What do you think ?

> 
> I don't think you need to provide the versioned symlinks: they are only used
> when two versions of an application can be installed that behave
> *differently* for python2 and python3. Here, if python3 support is added in
> the future, there will be no difference in behaviour when running under
> python2 and python3, IIUC.

Done
Comment 3 Zbigniew Jędrzejewski-Szmek 2017-02-22 04:24:06 UTC 
Two small issues:
- COPYING is listed twice in %files
- the %description suggests that this is a GUI application. It'd be nice to reword it somehow to say that this is a backend for a browser interface.

+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ latest version
+ builds and installs correctly
+ Provides/Requires/BuildRequires appear correct
+ no scriptlets

> I try another approch, it add a new warning in rpmlint but the SPEC is more clean. What do you think ?

Nah, I think this is OK.

Package is APPROVED.
Comment 4 Fedora Update System 2017-02-22 21:46:17 UTC 
prewikka-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2
Comment 5 Fedora Update System 2017-02-22 21:46:25 UTC 
prewikka-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627
Comment 6 Fedora Update System 2017-02-22 22:55:01 UTC 
prewikka-3.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4
Comment 7 Fedora Update System 2017-02-23 19:51:38 UTC 
prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4
Comment 8 Fedora Update System 2017-02-23 22:22:51 UTC 
prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627
Comment 9 Fedora Update System 2017-02-23 23:21:11 UTC 
prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2
Comment 10 Fedora Update System 2017-03-07 13:21:22 UTC 
prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2017-03-08 13:27:40 UTC 
prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2017-03-10 11:20:03 UTC 
prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.