Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1428551 - Review Request: golang-github-kardianos-osext - Extensions (Executable and ExecutableFolder) for go's os
Summary: Review Request: golang-github-kardianos-osext - Extensions (Executable and Ex...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1297545 (view as bug list)
Depends On:
Blocks: 1426972 1427634
TreeView+ depends on / blocked
 
Reported: 2017-03-02 19:41 UTC by Fabio Valentini
Modified: 2017-03-04 20:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-04 14:06:02 UTC
Type: ---
Embargoed:
jchaloup: fedora-review?

Attachments (Terms of Use)

Description Fabio Valentini 2017-03-02 19:41:00 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-kardianos-osext.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-kardianos-osext-0-0.1.git9b883c5.fc25.src.rpm

Description: Extensions (Executable and ExecutableFolder) for go's os

Fedora Account System Username: decathorpe

koji scratch builds for rawhide:
- https://koji.fedoraproject.org/koji/taskinfo?taskID=18140275
- https://koji.fedoraproject.org/koji/taskinfo?taskID=18140332


PS: The .spec file was generated by gofed. The tests fail spuriously on "slow" arches, I'm guessing it's a race condition in one of the tests (supported by the test output). I have reported this issue upstream at [1].

I can either wait for upstream to fix the tests, or temporarily ignore test results (which wouldn't be too bad, since it's probably the test that is broken, not the code).

[1]: https://github.com/kardianos/osext/issues/21
Comment 1 Jan Chaloupka 2017-03-03 12:55:48 UTC 
The package already exists: https://koji.fedoraproject.org/koji/packageinfo?packageID=17130
Comment 2 Fabio Valentini 2017-03-03 13:47:48 UTC 
I didn't see that - but upstream has not only changed code hosting provider, but also changed the package's import path - and syncthing depends on the new import name.

According to the contents of the bitbucket repository, upstream has moved from there to github in Feb 2015. Since then, development happened on github only.
Comment 3 Jan Chaloupka 2017-03-03 13:55:07 UTC 
In this case I just add additional package into golang-bitbucket-kardianos-osext so it provides both the old one and the new one. The package name does not matter, only virtual provides that are available. In any case, you can always change subpackage name into golang-github-bitbucket-osext-devel.

Have just given you commit permissions for the package. You can extend it. E.g. take a look at [1] how it is done.

[1] http://pkgs.fedoraproject.org/cgit/rpms/golang-googlecode-net.git/tree/golang-googlecode-net.spec
Comment 4 Fabio Valentini 2017-03-03 14:35:10 UTC 
This doesn't seem to work, because if installing code to both import prefixes, I get the following error:

+ go test -compiler gc -ldflags '' bitbucket.org/kardianos/osext
can't load package: package bitbucket.org/kardianos/osext: code in directory /builddir/build/BUILDROOT/golang-bitbucket-kardianos-osext-0-0.15.git9b883c5.fc25.x86_64/usr/share/gocode/src/bitbucket.org/kardianos/osext expects import "github.com/kardianos/osext"

If I disable tests for the old import prefix, the package builds fine (and the built packages look good). But I suspect this doesn't only affect tests that use the old import prefix, but compilation of dependent packages (that expect the old import prefix), too ...

You can see the adapted .spec file at https://decathorpe.fedorapeople.org/packages/golang-bitbucket-kardianos-osext.spec
Comment 5 Jan Chaloupka 2017-03-03 14:46:54 UTC 
You need to preserve the old bitbucket tarball as well [1]

[1] http://pkgs.fedoraproject.org/cgit/rpms/golang-gopkg-yaml.git/tree/golang-gopkg-yaml.spec#n57
Comment 6 Fabio Valentini 2017-03-03 14:50:32 UTC 
Honestly, if *really everything* has to be duplicated, wouldn't 2 separate packages be simpler?
Comment 7 Fabio Valentini 2017-03-03 15:48:50 UTC 
Anyway, I managed to fix the .spec file so it uses both sources.

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-bitbucket-kardianos-osext.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-bitbucket-kardianos-osext-0-0.15.git9b883c5.fc27.src.rpm

If the .spec looks alright to you, I'll push the changes to fedora.
Comment 8 Jan Chaloupka 2017-03-03 15:58:10 UTC 
Not necessarily. It can happen the bitbucket gets retired over time. It is simplier to just change content of a package than create a new one and retire the old one. Plus, you have the entire history of the project in one place.
Comment 9 Fabio Valentini 2017-03-04 14:06:02 UTC 
I used rpmdiff to compare the old *bitbucket*-devel package with the one after I added my changes, and since there are no obvious mistakes, I'm pushing the update to rawhide, f26, f25 and f24.

If you want to push the new version to el6 and epel7 branches too, feel free to do that, but I have no experience with EPEL packaging, so I didn't want to touch those branch and break something by ignorance.
Comment 10 Ed Marshall 2017-03-04 20:00:27 UTC 
*** Bug 1297545 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.