Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in onboard
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in onboard
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in onboard
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database
- There are some whitespaces at EOLs


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "GPL (v3 or later)", "Unknown or generated".
     10 files have unknown license. Detailed output of licensecheck in
     /home/cheese/Personal/1431322-onboard/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/icons/hicolor/28x28,
     /usr/share/icons/hicolor/28x28/apps
[x]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/28x28, /usr/share/icons/HighContrast,
     /usr/share/gnome-shell, /usr/share/icons/HighContrast/scalable/apps,
     /usr/share/icons/HighContrast/scalable, /usr/share/gnome-
     shell/extensions, /usr/share/icons/hicolor/28x28/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in onboard-
     debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 22108160 bytes in /usr/share
     onboard-1.4.1-1.fc24.x86_64.rpm:22108160
     See:
     http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)


Rpmlint
-------
Checking: onboard-1.4.1-1.fc24.x86_64.rpm
          onboard-debuginfo-1.4.1-1.fc24.x86_64.rpm
          onboard-1.4.1-1.fc24.src.rpm
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/layouts 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/themes 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/scripts 2755
onboard.x86_64: E: non-standard-dir-perm /usr/lib64/python3.5/site-packages/Onboard/pypredict/__pycache__ 2755
onboard.x86_64: E: non-standard-dir-perm /usr/lib64/python3.5/site-packages/Onboard/pypredict 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/gnome-shell/extensions/Onboard_Indicator 2755
onboard.x86_64: E: non-standard-dir-perm /usr/lib64/python3.5/site-packages/Onboard/__pycache__ 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/layouts/images 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/tools 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/gnome-shell/extensions/Onboard_Indicator/schemas 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/models 2755
onboard.x86_64: E: non-standard-dir-perm /usr/lib64/python3.5/site-packages/Onboard 2755
onboard.x86_64: E: non-standard-dir-perm /usr/share/doc/onboard 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/onboard-1.4.1/Onboard/pypredict 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/onboard-1.4.1/Onboard/osk 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/onboard-1.4.1/Onboard 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/onboard-1.4.1/Onboard/pypredict/lm 2755
onboard-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/onboard-1.4.1 2755
3 packages and 0 specfiles checked; 20 errors, 0 warnings.




Diff spec file in url and in SRPM
---------------------------------
--- /home/cheese/Personal/1431322-onboard/srpm/onboard.spec	2017-03-13 14:22:58.303853297 +0800
+++ /home/cheese/Personal/1431322-onboard/srpm-unpacked/onboard.spec	2017-03-11 05:15:49.000000000 +0800
@@ -32,8 +32,4 @@
 BuildRequires:      systemd-devel
 
-Requires:           iso-codes
-Requires:           dbus-X11
-Requires:           python3-gobject
-
 %description
 Onboard is an onscreen keyboard useful for everybody that cannot use a
@@ -56,5 +52,6 @@
 
 install -dm 0755 %{buildroot}%{_datadir}/applications
-cp %{_builddir}/%{name}-%{version}/build/share/applications/%{name}*.desktop %{buildroot}%{_datadir}/applications/
+cp %{_builddir}/%{name}-%{version}/build/share/applications/%{name}.desktop %{buildroot}%{_datadir}/applications/%{name}.desktop
+cp %{_builddir}/%{name}-%{version}/build/share/applications/%{name}-settings.desktop %{buildroot}%{_datadir}/applications/%{name}-settings.desktop
 
 # Remove icons for Ubuntu 
@@ -71,5 +68,5 @@
 %files
 %doc AUTHORS NEWS README
-%license COPYING
+%license 
 %{_bindir}/%{name}*
 %{_datadir}/%{name}/


Requires
--------
onboard (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python3
    libX11.so.6()(64bit)
    libXi.so.6()(64bit)
    libXtst.so.6()(64bit)
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libcanberra.so.0()(64bit)
    libdconf.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libhunspell-1.3.so.0()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libpython3.5m.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libxkbfile.so.1()(64bit)
    python(abi)
    rtld(GNU_HASH)

onboard-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
onboard:
    application()
    application(onboard-settings.desktop)
    application(onboard.desktop)
    mimehandler(application/x-onboard)
    mimehandler(application/x-onboardsettings)
    onboard
    onboard(x86-64)

onboard-debuginfo:
    onboard-debuginfo
    onboard-debuginfo(x86-64)



Unversioned so-files
--------------------
onboard: /usr/lib64/python3.5/site-packages/Onboard/osk.cpython-35m-x86_64-linux-gnu.so
onboard: /usr/lib64/python3.5/site-packages/Onboard/pypredict/lm.cpython-35m-x86_64-linux-gnu.so

Source checksums
----------------
https://launchpad.net/onboard/1.4/1.4.1/+download/onboard-1.4.1.tar.gz :
  CHECKSUM(SHA256) this package     : 01cae1ac5b1ef1ab985bd2d2d79ded6fc99ee04b1535cc1bb191e43a231a3865
  CHECKSUM(SHA256) upstream package : 01cae1ac5b1ef1ab985bd2d2d79ded6fc99ee04b1535cc1bb191e43a231a3865


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1431322
Buildroot used: fedora-24-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

On it, thank you!

A quick question should 2755 permissions be changed to 0755? First time I see something like this.

Thanks!

(In reply to Nemanja Milosevic from comment #2)
> On it, thank you!
> 
> A quick question should 2755 permissions be changed to 0755? First time I
> see something like this.
Directories should be usually 0755.
> 
> Thanks!

(In reply to Robin Lee from comment #1)
> Issues:
> =======
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file COPYING is not marked as %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Fixed this one, it actually should say GPLv3 and BSD, because some files are licensed separately.

> - glib-compile-schemas is run in %postun and %posttrans if package has
>   *.gschema.xml files.
>   Note: gschema file(s) in onboard
>   See:
>   http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

This one I left out, because the Packaging guidelines specifically say not to use glib-compile-schemas on F23+ and I am building for F24+.

> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in onboard
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Fixed.

> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.

Fixed.

> - update-desktop-database is invoked in %post and %postun if package
>   contains desktop file(s) with a MimeType: entry.
>   Note: desktop file(s) with MimeType entry in onboard
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
>   database

Fixed.

> - There are some whitespaces at EOLs

Fixed.

> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "BSD (3 clause)", "GPL (v3 or later)", "Unknown or generated".
>      10 files have unknown license. Detailed output of licensecheck in
>      /home/cheese/Personal/1431322-onboard/licensecheck.txt

As stated above, fixed.

> [!]: %check is present and all tests pass.

There are no tests, but I now mention it in the spec file.

> [!]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
>      Note: Arch-ed rpms have a total of 22108160 bytes in /usr/share
>      onboard-1.4.1-1.fc24.x86_64.rpm:22108160
>      See:

Split into onboard and onboard-data which is noarch now. 
     
> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

Modified it after the build to include a license properly last time, sorry! :(

> 
> Rpmlint
> -------
> Checking: onboard-1.4.1-1.fc24.x86_64.rpm
>           onboard-debuginfo-1.4.1-1.fc24.x86_64.rpm
>           onboard-1.4.1-1.fc24.src.rpm
> onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/layouts 2755
> onboard.x86_64: E: non-standard-dir-perm /usr/share/onboard/themes 2755
> ...

Fixed.

New SPEC: https://pagure.io/onboard-rpm/raw/master/f/onboard.spec
New SRPM: https://copr-be.cloud.fedoraproject.org/results/nmilosev/onboard/fedora-25-x86_64/00527023-onboard/onboard-1.4.1-2.fc25.src.rpm

New builds are also on COPR.

Last note, on one of my machines packages build normally, but on the other rpmlint throws a lot of errors with python-bytecode-wrong-magic-value like here also: https://bugzilla.redhat.com/show_bug.cgi?id=1409376 (the package still builds and works just fine - Py 3.5.2)

Any ideas what is the reason

Thank you again for your thorough review!

Kind regards,
Nemanja

1. There are still three whitespaces at EOLs.
2. Description of data subpackage should end with a period.
3. A comment should be included to specify which file is under BSD.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

4. License and documents can be included only in the data subpackage. since it is required by the base one.
5. update-desktop-database should not be used in Fedora 25 or later. You can make a condition to filter some statements out:
%if 0%{?fedora} < 25
xxxx
%endif

After all, these are not blocking conditions. Just fix them before importing the package.

This package is approved by cheeselee.

New SPEC: https://pagure.io/onboard-rpm/raw/master/f/onboard.spec
New COPR build (currently building): https://copr.fedorainfracloud.org/coprs/nmilosev/onboard/build/527211/

I couldn't for the life of me find three trailing whitespaces, only found one (using gedit).

Thank you again so much for helping me.

Kind regards,
Nemanja

(In reply to Nemanja Milosevic from comment #6)
> New SPEC: https://pagure.io/onboard-rpm/raw/master/f/onboard.spec
> New COPR build (currently building):
> https://copr.fedorainfracloud.org/coprs/nmilosev/onboard/build/527211/
> 
> I couldn't for the life of me find three trailing whitespaces, only found
> one (using gedit).
And line 61 and 172. Use Emacs.

These lines should be also filtered for Fedora 25 and later.
Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

There should be one js file under BSD.
onboard-1.4.1/gnome/Onboard_Indicator/convenience.js

And there are still some more noarch files can be moved to the data subpackage.

> 
> Thank you again so much for helping me.
> 
> Kind regards,
> Nemanja

Hopefully everything is fixed now! :)

https://copr.fedorainfracloud.org/coprs/nmilosev/onboard/build/527299/

https://pagure.io/onboard-rpm/raw/master/f/onboard.spec

onboard-1.4.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a8ac7ff05

onboard-1.4.1-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e075b2a9c

onboard-1.4.1-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5a8ddf300

onboard-1.4.1-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a8ac7ff05

onboard-1.4.1-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5a8ddf300

onboard-1.4.1-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e075b2a9c

onboard-1.4.1-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

onboard-1.4.1-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

onboard-1.4.1-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.