Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1431362 (php-google-apiclient-services) - Review Request: php-google-apiclient-services - Client library for Google APIs
Summary: Review Request: php-google-apiclient-services - Client library for Google APIs
Keywords:
Status: CLOSED ERRATA
Alias: php-google-apiclient-services
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1438295 1386152
TreeView+ depends on / blocked
 
Reported: 2017-03-11 16:08 UTC by Shawn Iwinski
Modified: 2017-04-09 05:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-09 05:59:05 UTC
Type: ---
Embargoed:
fedora: fedora-review+

Attachments (Terms of Use)
phpci.log (677.66 KB, text/plain)
2017-03-12 05:57 UTC, Remi Collet 		no flags Details
review.txt (7.57 KB, text/plain)
2017-03-12 05:57 UTC, Remi Collet 		no flags Details
View All

Description Shawn Iwinski 2017-03-11 16:08:29 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ce04869657f814492a821b089d4f016c7719ae16/php-google-apiclient-services/php-google-apiclient-services.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-google-apiclient-services-0.10-1.fc25.src.rpm

Description:
Client library for Google APIs.


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2017-03-12 05:57:23 UTC 
Created attachment 1262191 [details]
phpci.log

     Note: phpCompatInfo version 5.0.4 DB version 1.18.0 built Feb 24 2017
     14:37:58 CET static analyze results
Comment 2 Remi Collet 2017-03-12 05:57:52 UTC 
Created attachment 1262192 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1431362
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Comment 3 Remi Collet 2017-03-12 05:58:42 UTC 
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/Google(php-
     google-apiclient), /usr/share/php/Google/Service(php-google-apiclient)

	=> ok, package splitted, conflicts present

[x]: %check is present and all tests pass.

	=> need to raise memory_limit for local build and php56


[x]: Package complies to the Packaging Guidelines


No blockers

=== APPROVED ===
Comment 4 Remi Collet 2017-03-12 06:03:03 UTC 
BTW, I just noticed (bug #1386152) you plan to create a php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ?
Comment 5 Shawn Iwinski 2017-03-12 21:18:38 UTC 
(In reply to Remi Collet from comment #4)
> BTW, I just noticed (bug #1386152) you plan to create a
> php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ?

I'm rethinking that comment... https://bugzilla.redhat.com/show_bug.cgi?id=1386152#c7
Comment 6 Shawn Iwinski 2017-03-22 16:39:08 UTC 
Which option do you prefer?:

1) Create a "php-google-apiclient1" package that deprecates "php-google-apiclient < 2" and installs to "/usr/share/php/Google1"

2) Install this "php-google-apiclient-services" v0.10 package to "/usr/share/php/Google2" even though this package is neither the apiclient library nor is it v2.



IMO, #1 because #2 installs to a location that doesn't really pertain to this package.  I'm all for creating versioned install directories when they make sense, but I don't think it makes sense to install this package into a "Google2" directory.  This package stand-alone doesn't make sense to install into "Google2".
Comment 7 Remi Collet 2017-03-24 08:33:23 UTC 
I agree with you, #1 seems better
Comment 8 Remi Collet 2017-04-03 06:36:20 UTC 
php-google-apiclient1 is now available in rawhide.
Comment 9 Shawn Iwinski 2017-04-03 17:02:46 UTC 
THANKS for the review.  Pkgdb request submitted for rawhide and f26 (just like php-google-apiclient1).
Comment 10 Gwyn Ciesla 2017-04-03 17:14:12 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-google-apiclient-services
Comment 11 Fedora Update System 2017-04-03 19:57:23 UTC 
php-google-apiclient-services-0.11-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-76e0ca4687
Comment 12 Fedora Update System 2017-04-04 23:52:12 UTC 
php-google-apiclient-services-0.11-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-76e0ca4687
Comment 13 Fedora Update System 2017-04-09 05:59:05 UTC 
php-google-apiclient-services-0.11-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.