Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1431450 - Review Request: impallari-raleway-fonts - Elegant sans-serif typeface family
Summary: Review Request: impallari-raleway-fonts - Elegant sans-serif typeface family
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2017-03-12 16:59 UTC by Fabio Valentini
Modified: 2017-11-11 17:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-09 16:44:00 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2017-03-12 16:59:22 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts-3.0-1.git161116.6c67ab1.fc25.src.rpm

Description: Elegant sans-serif typeface family

Fedora Account System Username: decathorpe


I used a snapshot of the github repository as the target for packaging since upstream doesn't seem to provide proper tarballs / zip files of the latest "stable" state of the font (v3.0).
Comment 1 Neal Gompa 2017-03-12 18:30:21 UTC 
Taking this review.
Comment 2 Fabio Valentini 2017-04-04 10:10:19 UTC 
Ping.
Comment 3 Neal Gompa 2017-04-04 17:22:08 UTC 
> %global commit_date     161116

Please use the fuller, unambiguous date form (YYYYMMDD). I can't tell what this date actually is.
Comment 4 Fabio Valentini 2017-04-04 18:26:49 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.src.rpm
Comment 5 Neal Gompa 2017-04-05 02:57:11 UTC 
Review notes:

[x] Package is named according to packaging guidelines for fonts
[x] fontconfig snippet looks fine
[x] No relevant rpmlint issues.
[!] Missing metainfo file for fonts to show up in software centers
    * Please add an AppStream metainfo file for the font. As an example: http://pkgs.fedoraproject.org/cgit/rpms/aajohan-comfortaa-fonts.git/tree/aajohan-comfortaa.metainfo.xml
Comment 6 Fabio Valentini 2017-04-07 08:47:09 UTC 
1) Added AppStream metadata file
2) Added validation check in %check

Spec URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1.src.rpm
Comment 7 Neal Gompa 2017-04-07 12:41:58 UTC 
Looks good to me now.

PACKAGE APPROVED.
Comment 8 Fabio Valentini 2017-04-07 13:09:12 UTC 
Thanks for the review!
Comment 9 Gwyn Ciesla 2017-04-07 14:08:47 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/impallari-raleway-fonts
Comment 10 Fedora Update System 2017-04-07 15:13:20 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37c547ee61
Comment 11 Fedora Update System 2017-04-07 15:16:11 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-41d13acccf
Comment 12 Fedora Update System 2017-04-09 04:23:54 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-41d13acccf
Comment 13 Fedora Update System 2017-04-09 05:53:09 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-37c547ee61
Comment 14 Fedora Update System 2017-04-09 16:44:00 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc26.1 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2017-04-09 21:52:53 UTC 
impallari-raleway-fonts-3.0-1.git20161116.6c67ab1.fc25.1 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.