Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1431741 - Review Request: golang-github-cznic-b - B+ Tree implementation in Go
Summary: Review Request: golang-github-cznic-b - B+ Tree implementation in Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Athos Ribeiro
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1246526 1431587 1431732 1431736
Blocks: 1431748
TreeView+ depends on / blocked
 
Reported: 2017-03-13 16:41 UTC by Fabio Valentini
Modified: 2017-04-27 05:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-26 18:20:11 UTC
Type: ---
Embargoed:
athoscribeiro: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2017-03-13 16:41:50 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-b.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-b-0-0.1.gitbcff30a.fc25.src.rpm

Description: B+ Tree implementation in Go

Fedora Account System Username: decathorpe


This package is one of the (indirect) dependencies of syncthing. I can't provide a koji scratch build yet, since it depends on golang-github-cznic-{mathutil,fileutil,strutil} for unit tests.

Comment 1 Fabio Valentini 2017-04-04 19:46:44 UTC
koji scratch build for rawhide, now that all dependencies are available: https://koji.fedoraproject.org/koji/taskinfo?taskID=18784743

Comment 2 Athos Ribeiro 2017-04-17 13:57:36 UTC
Hello Fabio,

I am taking this review.

- The Revision shuld be updated to reflect new guidelines. For pre-releases packages, the date MUST be included in the tag.

- The conditional in line 142 seems to be duplicated, that could be fixed to clean up the spec file.

Other than that, the package looks good. I will trust you will perform the necessary changes before uploading the package.

Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-cznic-b-devel-0-0.1.gitbcff30a.fc27.noarch.rpm
          golang-github-cznic-b-unit-test-devel-0-0.1.gitbcff30a.fc27.x86_64.rpm
          golang-github-cznic-b-0-0.1.gitbcff30a.fc27.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
golang-github-cznic-b-devel (rpmlib, GLIBC filtered):

golang-github-cznic-b-unit-test-devel (rpmlib, GLIBC filtered):
    golang(github.com/cznic/fileutil)
    golang(github.com/cznic/mathutil)
    golang(github.com/cznic/strutil)
    golang-github-cznic-b-devel



Provides
--------
golang-github-cznic-b-devel:
    golang(github.com/cznic/b)
    golang-github-cznic-b-devel

golang-github-cznic-b-unit-test-devel:
    golang-github-cznic-b-unit-test-devel
    golang-github-cznic-b-unit-test-devel(x86-64)



Source checksums
----------------
https://github.com/cznic/b/archive/bcff30a622dbdcb425aba904792de1df606dab7c/cznic-b-bcff30a.tar.gz :
  CHECKSUM(SHA256) this package     : 3c73f62b16abafe2703a595ea90b0ba95073a627538b02a886c32b9ccbaa4dee
  CHECKSUM(SHA256) upstream package : 3c73f62b16abafe2703a595ea90b0ba95073a627538b02a886c32b9ccbaa4dee

Comment 3 Fabio Valentini 2017-04-17 14:23:23 UTC
Thanks for the review, I've already incorporated fixes for the issues you've pointed out in the linked .spec file.

Comment 4 Gwyn Ciesla 2017-04-17 15:03:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-b

Comment 5 Fedora Update System 2017-04-17 15:57:02 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e740cb75e8

Comment 6 Fedora Update System 2017-04-17 15:58:32 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d0f8f446c6

Comment 7 Fedora Update System 2017-04-17 16:01:14 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-900cdba78a

Comment 8 Fedora Update System 2017-04-18 13:22:21 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d0f8f446c6

Comment 9 Fedora Update System 2017-04-18 17:52:03 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-900cdba78a

Comment 10 Fedora Update System 2017-04-18 19:53:01 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e740cb75e8

Comment 11 Fedora Update System 2017-04-26 18:20:11 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2017-04-27 05:51:19 UTC
golang-github-cznic-b-0-0.1.20170413.git6955404.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.