Updated .spec and SRPM files for the newest 0.8.6 upstream release:

Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.6-1.fc26.src.rpm

Updated .spec and SRPM files for the newest 0.8.7 upstream release:

Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.7-1.fc26.src.rpm

The package does not build in rawhide due to an error [1]

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21229077

[1] ./syncwatcher.go:503:23: cannot use false (type bool) as type ignore.Option in argument to ignore.New

Yes, I know. This is due to an incompatibility with a changed API in syncthing 0.14.33+.

I have a patch from upstream that fixes the compilation. However, the tests fail when run against the new version. I still have to investigate why.

Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.7-3.fc26.src.rpm

Changes:
- I've added a systemd user-preset (just like in the syncthing package itself), to make extra sure that no services get started accidentally.

- I've disabled tests for now, since they are failing quite randomly (this issue has been reported upstream at [1]).

- I've also fixed the ldflags issue which prevented building with the new -debuginfo and -debugsource sub-packages.

new koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21280774

[1]: https://github.com/syncthing/syncthing-inotify/issues/150

Hi Fabio,

- Is there any reason for using Supplements: here? As I understood it in [1],
you should use Recommends in syncthing instead, if you believe both packages
should be installed.

- There are a few rpmlint warnings/error which may require your attention, in special, the permissions for your patch:
syncthing-inotify.x86_64: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify.x86_64: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify.src: W: strange-permission 00-syncthing-01433-bump.patch 600

- It would be nice to add a comment with a link to the github issue or the PR that led to the patch

%check is not mandatory here, so it is ok to comment the failing tests: the issue pointed shows that there is a problem with them. The package looks good. I will wait for your feedback on the Supplements and patch permission issues before approving it, but fixing those would do it for me.

[1] https://fedoraproject.org/wiki/Packaging:WeakDependencies#Forward_vs_Backward_Dependencies

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id(syncthing,
     jackthejanitor)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
  There is a comment on the Supplements line though.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: syncthing-inotify-0.8.7-3.fc27.x86_64.rpm
          syncthing-inotify-devel-0.8.7-3.fc27.noarch.rpm
          syncthing-inotify-unit-test-devel-0.8.7-3.fc27.x86_64.rpm
          syncthing-inotify-debuginfo-0.8.7-3.fc27.x86_64.rpm
          syncthing-inotify-0.8.7-3.fc27.src.rpm
syncthing-inotify.x86_64: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify.x86_64: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
syncthing-inotify.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
syncthing-inotify.x86_64: W: no-manual-page-for-binary syncthing-inotify
syncthing-inotify-devel.noarch: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify-devel.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify-unit-test-devel.x86_64: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify-unit-test-devel.x86_64: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify-debuginfo.x86_64: E: debuginfo-without-sources
syncthing-inotify.src: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify.src: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify.src: W: strange-permission 00-syncthing-01433-bump.patch 600
syncthing-inotify.src:145: E: hardcoded-library-path in %{_prefix}/lib/systemd/user-preset
syncthing-inotify.src:146: E: hardcoded-library-path in %{_prefix}/lib/systemd/user-preset/90-syncthing-inotify.preset
syncthing-inotify.src:230: E: hardcoded-library-path in %{_prefix}/lib/systemd/user-preset/90-%{name}.preset
5 packages and 0 specfiles checked; 4 errors, 12 warnings.




Rpmlint (debuginfo)
-------------------
Checking: syncthing-inotify-debuginfo-0.8.7-3.fc27.x86_64.rpm
syncthing-inotify-debuginfo.x86_64: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
syncthing-inotify-devel.noarch: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify-devel.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify-unit-test-devel.x86_64: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify-unit-test-devel.x86_64: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify-debuginfo.x86_64: E: debuginfo-without-sources
syncthing-inotify.x86_64: W: spelling-error %description -l en_US rescan -> re scan, re-scan, res can
syncthing-inotify.x86_64: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity
syncthing-inotify.x86_64: W: no-manual-page-for-binary syncthing-inotify
4 packages and 0 specfiles checked; 1 errors, 7 warnings.



Requires
--------
syncthing-inotify-devel (rpmlib, GLIBC filtered):

syncthing-inotify-unit-test-devel (rpmlib, GLIBC filtered):
    syncthing-inotify-devel

syncthing-inotify-debuginfo (rpmlib, GLIBC filtered):

syncthing-inotify (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)
    syncthing
    systemd



Provides
--------
syncthing-inotify-devel:
    golang(github.com/syncthing/syncthing-inotify)
    golang-github-syncthing-syncthing-inotify-devel
    syncthing-inotify-devel

syncthing-inotify-unit-test-devel:
    syncthing-inotify-unit-test-devel
    syncthing-inotify-unit-test-devel(x86-64)

syncthing-inotify-debuginfo:
    debuginfo(build-id)
    syncthing-inotify-debuginfo
    syncthing-inotify-debuginfo(x86-64)

syncthing-inotify:
    golang-github-syncthing-syncthing-inotify
    syncthing-inotify
    syncthing-inotify(x86-64)



Source checksums
----------------
https://github.com/syncthing/syncthing-inotify/archive/v0.8.7/syncthing-inotify-0.8.7.tar.gz :
  CHECKSUM(SHA256) this package     : e5ba978039de457f35f2923d0e97b163e412c55104d275c2ba211ce99d05e633
  CHECKSUM(SHA256) upstream package : e5ba978039de457f35f2923d0e97b163e412c55104d275c2ba211ce99d05e633

- Supplements vs. Recommends:

There was a reason, because no syncthing-inotify existed in fedora when I built syncthing, and adding "Recommends" on a third-party package is forbidden.

Since both packages will soon be in the official fedora repositories, I can remove the "Supplements" tag from syncthing-inotify and then add a "Recommends" tag to syncthing once the syncthing-inotify package is in the repositories.

- Wrong permissions on patch:

Sorry about that, I didn't notice. The patch is the autogenerated one from the github pull request, and I didn't check for file permissions (who would?).


Remaining rpmlint issues when built locally in mock:

- Spelling error (synchronisation, rescan): The text is from the upstream README. I don't want to change "fix" it downstream.

- Hardcoded library path: No way around this, but systemd will soon (TM) ship the missing macro to fix this. And in a way, this is a false positive anyway.

The rest of the message are false positives.


Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.7-4.fc26.src.rpm

Thanks for the comments and fixes!

Package approved!

Thank you for the review!

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/syncthing-inotify

syncthing-inotify-0.8.7-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8e9d66545

syncthing-inotify-0.8.7-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c8197a9286

syncthing-inotify-0.8.7-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8e9d66545

syncthing-inotify-0.8.7-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

syncthing-inotify-0.8.7-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.