Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1441803 (kproperty) - Review Request: kproperty - Property editing framework with editor widget
Summary: Review Request: kproperty - Property editing framework with editor widget
Keywords:
Status: CLOSED ERRATA
Alias: kproperty
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kreport calligra3 kexi
TreeView+ depends on / blocked
 
Reported: 2017-04-12 18:23 UTC by Rex Dieter
Modified: 2017-06-26 19:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-26 19:11:54 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Rex Dieter 2017-04-12 18:23:08 UTC 
Spec URL: https://rdieter.fedorapeople.org/rpms/calligra3/kproperty.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/calligra3/kproperty-3.0.1-1.fc25.src.rpm
Description: A property editing framework with editor widget similar to what is known from Qt Designer.

Fedora Account System Username: rdieter
Comment 1 Rex Dieter 2017-04-12 18:23:34 UTC 
Sample/test builds in copr (since there are several that depend on each other):

https://copr.fedorainfracloud.org/coprs/rdieter/calligra3
Comment 2 Zbigniew Jędrzejewski-Szmek 2017-06-19 15:01:17 UTC 
%description should be wrapped to <80 columns.

Url, Source0: http → https.

Rpmlint
-------
Checking: kproperty-3.0.1-1.fc27.x86_64.rpm
          kproperty-devel-3.0.1-1.fc27.x86_64.rpm
          kproperty-debuginfo-3.0.1-1.fc27.x86_64.rpm
          kproperty-3.0.1-1.fc27.src.rpm
kproperty.x86_64: E: description-line-too-long C A property editing framework with editor widget similar to what is 
known from Qt Designer.
kproperty.src: E: description-line-too-long C A property editing framework with editor widget similar to what is known from Qt Designer.
Right.

kproperty.x86_64: W: no-documentation
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty-devel.x86_64: W: only-non-binary-in-usr-lib
kproperty-devel.x86_64: W: no-documentation
The rest is OK.

kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyCore3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyCore3.so.3.0 /lib64/libgcc_s.so.1
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libKF5ConfigGui.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libQt5Xml.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libgcc_s.so.1
Hm, those might be worth cleaning up. At least libKF5ConfigGui, libQt5Xml.

+ package name is OK
+ licence is acceptable for Fedora (LGPLv2+)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look correct
  (some Requires might be trimmed possibly)
+ scriptlets follow the guidelines
+ fedora-review finds no issues

Package is APPROVED.
Comment 3 Gwyn Ciesla 2017-06-19 17:55:29 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kproperty
Comment 4 Fedora Update System 2017-06-20 16:44:16 UTC 
kreport-3.0.1-1.fc26 kproperty-3.0.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291
Comment 5 Fedora Update System 2017-06-21 06:24:37 UTC 
kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291
Comment 6 Fedora Update System 2017-06-26 19:11:54 UTC 
kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.