Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1442510 - Review Request: nodejs-shallow-clone - Make a shallow clone of an object, array or primitive
Summary: Review Request: nodejs-shallow-clone - Make a shallow clone of an object, arr...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1442508
Blocks: nodejs-reviews Node-RED 1442511
TreeView+ depends on / blocked
 
Reported: 2017-04-15 01:12 UTC by Jared Smith
Modified: 2017-09-18 14:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-18 14:29:33 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2017-04-15 01:12:51 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-shallow-clone/nodejs-shallow-clone.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-shallow-clone/nodejs-shallow-clone-0.1.2-2.fc27.src.rpm
Description: Make a shallow clone of an object, array or primitive
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-09-14 15:40:27 UTC
Please bump the package to version 1.0.0.

You'll probably need to bump the versions in package.json to handle the dependencies correctly:

diff -up package/package.json.fix_metadata package/package.json
--- package/package.json.fix_metadata	2017-09-14 17:32:47.905729241 +0200
+++ package/package.json	2017-09-14 17:33:25.442646994 +0200
@@ -24,9 +24,9 @@
     "test": "mocha"
   },
   "dependencies": {
-    "is-extendable": "^0.1.1",
+    "is-extendable": "^1.0.0",
     "kind-of": "^5.0.0",
-    "mixin-object": "^2.0.1"
+    "mixin-object": "^3.0.0"
   },
   "devDependencies": {
     "gulp-format-md": "^1.0.0",

Comment 3 Robert-André Mauchin 🐧 2017-09-15 23:59:28 UTC
You should

%nodejs_fixdep is-extendable
%nodejs_fixdep mixin-object

otherwise you'll get issues with dependencies.

Comment 4 Jared Smith 2017-09-16 10:58:55 UTC
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1217'

Comment 5 Gwyn Ciesla 2017-09-18 11:15:59 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-shallow-clone

Comment 6 Jared Smith 2017-09-18 14:29:33 UTC
In rawhide, closing bug


Note You need to log in before you can comment on or make changes to this bug.