Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1442566 - Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins
Summary: Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews Node-RED 1442567
TreeView+ depends on / blocked
 
Reported: 2017-04-15 16:42 UTC by Jared Smith
Modified: 2021-06-23 05:48 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-22 17:45:47 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jared Smith 2017-04-15 16:42:42 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-valid-app/nodejs-is-valid-app.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-valid-app/nodejs-is-valid-app-0.3.0-1.fc27.src.rpm
Description: Wrapper around is-valid-instance and is-registered for validating base plugins
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-09-25 14:47:45 UTC 
Tests fail:

+ /usr/bin/mocha -R spec
  is-valid-app

    ✓ should export a function

    ✓ should return false if the instance is not valid

    1) should allow custom instance types

    ✓ should return false if a plugin is registered already
  3 passing (14ms)
  1 failing
  1) is-valid-app should allow custom instance types:
      AssertionError [ERR_ASSERTION]: 0 == 2
      + expected - actual
      +2
      -0
      
      at Context.<anonymous> (test.js:47:12)
Comment 2 Jared Smith 2018-07-19 21:21:12 UTC 
Can you please test again?  This is working fine for me:

https://koji.fedoraproject.org/koji/taskinfo?taskID=28446214
Comment 3 Robert-André Mauchin 🐧 2018-07-20 11:33:58 UTC 
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.
Comment 4 Mattia Verga 2021-06-10 09:16:38 UTC 
Package was never imported, it will need a fresh review.

Jared, are you still interested in packaging this?
Comment 5 Jared Smith 2021-06-22 17:45:47 UTC 
@mattia.verga No, I'm no longer doing any NodeJS packaging in Fedora.  Feel free to resubmit if you are interested in packaging it.
Comment 6 Mattia Verga 2021-06-23 05:48:29 UTC 
Thanks
Note You need to log in before you can comment on or make changes to this bug.