Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1442576 - Review Request: golang-github-restic-chunker - Implementation of Content Defined Chunking
Summary: Review Request: golang-github-restic-chunker - Implementation of Content Defi...
Keywords:
Status: CLOSED DUPLICATE of bug 1592482
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Athos Ribeiro
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2017-04-15 21:16 UTC by Philipp Baum
Modified: 2020-07-12 07:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-12 07:52:09 UTC
Type: ---
Embargoed:
athoscribeiro: fedora-review-


Attachments (Terms of Use)

Comment 2 Athos Ribeiro 2017-05-01 13:53:16 UTC
Hello Philipp,

I checked your FAS name [1] and as I see, you are not approved in the packager group yet. I suggest you read [2] if you did not do so yet. I am blocking FE-NEEDSPONSOR with this bug.

About your package:

- You should not generate an "empty" golang-github-restic-chunker with just a license file and a readme file. It's ok to generate just the -devel and the -unit-test subpackages if this package is a dependency for something else you want to package in Fedora. Note that if it is not a dependency for something, there is no point in packaging it: we recommend using 'go get' for development.

- There is no need for the content in the %%build section since there is no binary files associated with this package.

- You did disabled the builds of the devel and of the unit-tests subpackages, it means that this package generates a single binary package, with a README file and a LICENSE file. I do not believe that is useful at all. I guess you wanted to package, at least, the devel subpackage.

[1]
> User: philphil
> Approved Groups: cla_done cla_fpca

[2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Comment 3 Athos Ribeiro 2017-05-01 13:59:46 UTC
Also, if you want to go on with the process to become a packager, it would be nice to see a few informal package reviews from you.

Read [1] and [2], find some packages you would like to review and do so in an informal way: do not assign the ticket for yourself and inform the packager that is an informal review. Make sure the package adheres to the packaging guidelines. You can post links to your informal reviews here in this ticket as you perform them.

[1] https://fedoraproject.org/wiki/Package_Review_Process
[2] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

Comment 4 Package Review 2020-07-10 00:55:49 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 5 Athos Ribeiro 2020-07-12 07:52:09 UTC
The submitter did not respond to the first review in 2017. This has already been packaged in Fedora and I will close this of a dup of bz#1592482

*** This bug has been marked as a duplicate of bug 1592482 ***


Note You need to log in before you can comment on or make changes to this bug.