Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1455811 - fix %global pidfiledir and other references to legacy /var/run
Summary: fix %global pidfiledir and other references to legacy /var/run
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: mariadb
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Michal Schorm
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: https://koji.fedoraproject.org/koji/t...
Depends On:
Blocks: 1462688
TreeView+ depends on / blocked
 
Reported: 2017-05-26 07:58 UTC by dac.override
Modified: 2017-07-28 09:59 UTC (History)
7 users (show)

Fixed In Version: 3:10.1.24-4
Doc Type: Enhancement
Doc Text:
It would be a mistake for Fedora to remove the /var/run symlink, but it's worth keeping up to date with what the distro is doing.
Clone Of:
: 1462688 (view as bug list)
Environment:
Last Closed: 2017-07-28 09:59:41 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description dac.override 2017-05-26 07:58:20 UTC 
Description of problem:

%global pidfiledir %{_localstatedir}/run/%{daemon_name}

points to legacy /var/run, please make it:

%global pidfiledir /run/%{daemon_name}

Because Fedora cannot forever rely on the /var/run symlink hack and besides it potentially breaks other components that do expect that the /var/run -> /run move has been completed. (i would not be making an issue out of this if this issue did not affect me)

Here are some other occurences that should be addressed:

mysql.init.in: # pidfile: /var/run/@DAEMON_NAME@/@DAEMON_NAME@.pid
mysql.tmpfiles.d.in: d @PID_FILE_DIR@ 0755 mysql mysql -

There is no reason to keep relying on the /var/run symlink. The /var/run -> /run move should have been completed a long time ago.

The initscripts package should also be addressing this, and arguably this should just addressed tree wide (all rpm specs, all tmpfiles snippets and all service and socket units should be modified to reflect the new reality)

Only then can be truly say that the /var/run -> /run move was completed.
Comment 1 Igor Gnatenko 2017-06-19 08:02:44 UTC 
Use %{_rundir} instead.
Comment 2 Michal Schorm 2017-06-19 08:39:17 UTC 
I updated the path using "%{_rundir}".

All "@SOME_MACRO_HERE@" should be updated automaticly.
Comment 3 Michal Schorm 2017-06-19 11:54:18 UTC 
SELinux context is set correctly.
Bug cloned against community-mysql.
Comment 4 Michal Schorm 2017-06-20 10:05:51 UTC 
Changes pushed as version 3:10.1.24-4.

You can use a scratch build on the whiteboard for your usecase.

Since I updated MariaDB very recently, I'll wait until more changes accumulate for Bodhi update.

--

I'll leave this open until the update, so you'd get notified, once the package reach stable repositories.
Comment 5 Fedora Update System 2017-07-12 06:16:00 UTC 
mariadb-10.1.25-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c581dc391
Comment 6 Fedora Update System 2017-07-12 15:53:14 UTC 
mariadb-10.1.25-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a6f49afbd
Comment 7 Fedora Update System 2017-07-12 16:25:03 UTC 
mariadb-10.1.25-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ebeb4bb332
Comment 8 Fedora Update System 2017-07-12 18:22:25 UTC 
mariadb-10.1.25-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c581dc391
Comment 9 Fedora Update System 2017-07-17 04:52:43 UTC 
mariadb-10.1.25-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2017-07-27 19:50:06 UTC 
mariadb-10.1.25-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2017-07-27 21:52:12 UTC 
mariadb-10.1.25-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.