Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1457714 (plymouth-kcm) - Review Request: plymouth-kcm - KCM for setting plymouth theme
Summary: Review Request: plymouth-kcm - KCM for setting plymouth theme
Keywords:
Status: CLOSED RAWHIDE
Alias: plymouth-kcm
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2017-06-01 07:48 UTC by Martin Kyral
Modified: 2017-10-17 14:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-17 14:14:53 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+

Attachments (Terms of Use)
spec file (3.10 KB, text/x-matlab)
2017-06-01 07:55 UTC, Martin Kyral 		no flags Details
patch to use dracut instead of update-alternatives (6.10 KB, patch)
2017-06-01 07:57 UTC, Martin Kyral 		no flags Details | Diff
View All

Description Martin Kyral 2017-06-01 07:48:32 UTC 
Spec URL: attached
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/00558567-plymouth-kcm/plymouth-kcm-5.10.0-0.fc27.src.rpm
Description: This is a System Settings configuration module for configuring the
plymouth splash screen.
Fedora Account System Username: mkyral
Comment 1 Martin Kyral 2017-06-01 07:55:50 UTC 
Created attachment 1284031 [details]
spec file
Comment 2 Martin Kyral 2017-06-01 07:57:08 UTC 
Created attachment 1284033 [details]
patch to use dracut instead of update-alternatives
Comment 3 Jan Grulich 2017-06-15 12:13:39 UTC 
Spec URL: https://jgrulich.fedorapeople.org/plymouth-kcm.spec
SRPM URL: https://jgrulich.fedorapeople.org/plymouth-kcm-5.10.0-0.fc27.src.rpm

Uploaded to be able to use fedora-review.
Comment 4 Jan Grulich 2017-06-15 12:30:48 UTC 
1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done. 

2) This "%{_libdir}/qt5/plugins/kcms/kcm_plymouth.so" can be replaced with %{_kf5_qtplugindir} if I'm not mistaken, also __provides_exclude_from should point to that location.

3) + %postun /sbin/ldconfig
Comment 5 Martin Kyral 2017-06-19 12:51:19 UTC 
Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git.

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plymouth-kcm.git/tree/plymouth-kcm.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567863-plymouth-kcm/plymouth-kcm-5.10.2-0.fc25.src.rpm
Comment 6 Jan Grulich 2017-06-20 06:22:03 UTC 
Looks good to me now, note that the initial release version should be 1 and not 0.
Comment 7 Gwyn Ciesla 2017-06-26 12:44:33 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/plymouth-kcm
Comment 8 Rex Dieter 2017-10-17 14:14:53 UTC 
imported long ago, closing
Note You need to log in before you can comment on or make changes to this bug.