Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1458780 - Review Request: Recording - Records of user sessions
Summary: Review Request: Recording - Records of user sessions
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-06-05 12:55 UTC by Delyan Yanev
Modified: 2020-08-10 00:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:56:47 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fedora-review output (11.11 KB, text/plain)
2017-08-30 15:24 UTC, Alexander Ploumistos
no flags Details

Description Delyan Yanev 2017-06-05 12:55:23 UTC
Spec URL: https://delyanyanev.fedorapeople.org/recording.spec
SRPM URL: https://delyanyanev.fedorapeople.org/recording-1.0-1.fc25.src.rpm
Description: This is rpm package on whole process of recording of user sessions.
Fedora Account System Username:

Comment 1 Delyan Yanev 2017-06-07 08:41:10 UTC
Fedora Account System Username: delyanyanev

Comment 2 Delyan Yanev 2017-06-22 06:52:47 UTC
Hi folks, this is my first package hence I am also looking for a sponsor.
I would appreciate it if someone could review it and be a sponsor.

Thanks,
Delyan Yanev

Comment 3 Delyan Yanev 2017-07-19 07:13:41 UTC
Spec URL: https://delyanyanev.fedorapeople.org/recording.spec
SRPM URL: https://delyanyanev.fedorapeople.org/recording-1.0-1.fc26.src.rpm
Description: This is rpm package on whole process of recording of user sessions.
Fedora Account System Username: delyanyanev

Comment 4 Alexander Ploumistos 2017-08-26 19:27:08 UTC
(In reply to Delyan Yanev from comment #2)
> Hi folks, this is my first package hence I am also looking for a sponsor.
> I would appreciate it if someone could review it and be a sponsor.


Hello Delyan,

I found your package interesting, so I tried to build it, but the build fails on all arches in rawhide, see the logs from this scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21483571
There are some syntax errors in your spec file (the missing / that causes the build to fail, hardcoded paths instead of macros, the extraneous %clean section, etc.) and the %changelog section usually comes at the end.

I am not in the sponsors group, so I can't help you there. Having glanced at your spec file, I would suggest that you follow the steps outlined in http://fedoraproject.org/wiki/Join_the_package_collection_maintainers

I'm pretty sure that once you introduce yourself on the devel mailing list a sponsor will turn up. In the meantime, it would be a good idea to get acquainted with the various aspects of packaging in fedora, e.g.
http://fedoraproject.org/wiki/How_to_create_an_RPM_package
and
https://fedoraproject.org/wiki/Packaging:Guidelines
cover a lot of topics. When you feel more at ease with the whole process, you could do a couple of informal reviews, so that your prospective sponsor can see your grasp of things.

If you get stuck or if you would like to ask any questions, feel free to do so on the devel list or irc channel.

Best of luck
Alexander

Comment 5 Delyan Yanev 2017-08-29 13:40:20 UTC
Hello Alexander,

Thank you for your advises and the problem was that " %{_unitdir} " macro require " BuildRequires: systemd-units " into spec file. The results could you see:

https://koji.fedoraproject.org/koji/taskinfo?taskID=21528467

Also I will introduce myself in the devel mailing list for sponsorship.


Best Regards,
Delyan Yanev

Comment 6 Delyan Yanev 2017-08-30 11:39:53 UTC
This is a rpmlint result:

1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 7 Alexander Ploumistos 2017-08-30 15:24:52 UTC
Created attachment 1320161 [details]
fedora-review output

(In reply to Delyan Yanev from comment #6)
> This is a rpmlint result:
> 
> 1 packages and 1 specfiles checked; 0 errors, 0 warnings.


fedora-review, our automated review tool, has spotted a number of issues. Please see the attached file.

Comment 8 Package Review 2020-07-10 00:55:53 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 9 Package Review 2020-08-10 00:56:47 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.