Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1462467 (hollywood) - Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble
Summary: Review Request: hollywood - Fill your console with Hollywood melodrama techno...
Keywords:
Status: NEW
Alias: hollywood
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: speedometer cmatrix jp2a
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-06-17 21:26 UTC by Raphael Groner
Modified: 2021-03-03 19:49 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-22 06:08:13 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Raphael Groner 2017-06-17 21:26:53 UTC 
Spec URL: http://raphgro.fedorapeople.org//hollywood.spec
SRPM URL: http://raphgro.fedorapeople.org//hollywood-1.12-1.fc26.src.rpm

Description:
Fill your console with Hollywood melodrama techno-babble.
Comment 1 Raphael Groner 2017-06-17 21:51:40 UTC 
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=20057150
Comment 2 Raphael Groner 2017-09-22 10:45:34 UTC 
As agreed in IRC, review swap with bug #1487420.
Please feel free to set status and review flag.
Comment 3 Stephen Gallagher 2017-09-22 13:00:28 UTC 
Raphael, this package depends on mplayer, which is not in Fedora. You may want to package this for a different RPM repository.
Comment 4 Raphael Groner 2017-09-22 17:17:40 UTC 
You run into wrong assumptions. hollywood is just a wrapper script for all the optional tools (dependencies of this bug), if a tool is not found then it's not used. We may want to use weak dependencies here instead, I can remove mplayer.
Comment 5 Raphael Groner 2018-07-22 06:08:13 UTC 
I'll close here. There's going to be no progress in near future.
Thanks for your time to look into this request. Please feel free to use for another request if you think hollywood can be of any usefulness in Fedora.
Comment 6 Raphael Groner 2020-01-10 13:57:51 UTC 
I'll continue with this request.

Reviewer, are you still interested, too?
Comment 7 Stephen Gallagher 2020-01-10 14:22:44 UTC 
I don't have the time to work on this until next month, so I'd recommend finding a new reviewer. Sorry.
Comment 8 Raphael Groner 2020-01-10 16:49:54 UTC 
(In reply to Stephen Gallagher from comment #7)
> I don't have the time to work on this until next month, so I'd recommend
> finding a new reviewer. Sorry.

No problem. I've to see if I find the time by myself, either and too. Thanks for the quick reply.
Comment 9 Robert-André Mauchin 🐧 2020-01-12 21:02:14 UTC 
(In reply to Raphael Groner from comment #6)
> I'll continue with this request.
> 
> Reviewer, are you still interested, too?

Update the SPEC to get rid of non-Fedora stuff?
Comment 10 Raphael Groner 2020-02-07 03:46:14 UTC 
(In reply to Robert-André Mauchin from comment #9)

> Update the SPEC to get rid of non-Fedora stuff?

What do you mean with non-Fedora stuff? In case of mplayer, see comment #4 below.
Comment 11 Artur Frenszek-Iwicki 2020-02-16 02:11:57 UTC 
Regarding the mplayer issue, the Packaging Guidelines say that all dependencies must be solvable using only the Fedora repositories.
>All package dependencies (build-time or runtime, regular, weak or otherwise) MUST ALWAYS be satisfiable within the official Fedora repositories.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies

This means that if mplayer is not packaged for Fedora, it cannot be used as a Requires:, Recommends: or even Suggests:. 

>Version:        1.12
The launchpad site says that 1.20 has been released - please update the spec.
Comment 12 Raphael Groner 2020-02-16 06:21:18 UTC 
Thanks for the hints. I'm going to fix the mentioned issues ASAP.
Comment 13 Raphael Groner 2020-09-10 14:40:31 UTC 
> This means that if mplayer is not packaged for Fedora, it cannot be used as a Requires:, Recommends: or even Suggests:. 

TBH it's still not clear to me that this common policy applies _strictly_ also for weak dependencies as here mplayer counts in and mplayer is reasonable packaged in the widely used and generally available 3rdparty repository called rpmfusion.

Sorry for the long delay to work on this request.
Comment 14 Artur Frenszek-Iwicki 2020-09-10 21:05:40 UTC 
>it's still not clear to me that this common policy applies _strictly_ also for weak dependencies
The Weak Dependencies Policy is clear on this.

>As with regular dependencies, weak dependencies MUST be satisfiable within the official Fedora repositories.
https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/
Comment 15 Robert Scheck 2021-03-03 17:18:08 UTC 
Is the package usable at all, if no 3rd-party repository is enabled? So are then e.g. just minor features missing? If the answer is "no", the package should IMHO get part of a 3rd-pary repository. Aside of that, the latest version is 1.21 which might address the license workaround in the spec file?
Comment 16 Raphael Groner 2021-03-03 17:30:05 UTC 
Thanks for your interest.

(In reply to Robert Scheck from comment #15)
> Is the package usable at all, if no 3rd-party repository is enabled? 

"We may want to use weak dependencies here instead, I can remove mplayer."

> So are then e.g. just minor features missing?

Yes. Weak dependency (for mplayer) may not work for cross-repos.

> Aside of that, the latest version is 1.21 which might address the license workaround in the spec file?

ASL 2.0, see https://bazaar.launchpad.net/~kirkland/hollywood/trunk/view/head:/debian/copyright#L8

Though I fail to remember why added CC0 as well. Propably suggest from licensecheck script.

Indeed, packaging version 1.12 seems to be very conservative. Going to take a closer look into more current version with obviously more 3rd-party support, besides fixes.
https://bazaar.launchpad.net/~kirkland/hollywood/trunk/view/head:/debian/changelog
Comment 17 Robert Scheck 2021-03-03 17:44:22 UTC 
Honestly, if the package will require more and more dependencies from 3rd-party repositories with newer versions...does it really make sense for the Fedora repository?
Comment 18 Raphael Groner 2021-03-03 19:49:35 UTC 
Well, that would mean my first package for a 3rd party repo. But if it's still to skip mplayer only we should continue here.
Note You need to log in before you can comment on or make changes to this bug.