Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1465674 - AttributeError: 'Disk' object has no attribute 'getMaxLogicalPartitions'
Summary: AttributeError: 'Disk' object has no attribute 'getMaxLogicalPartitions'
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-blivet
Version: rawhide
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Blivet Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:1157833d8337ce611e74dbb9599...
Depends On:
Blocks: AlphaBlocker, F27AlphaBlocker
TreeView+ depends on / blocked
 
Reported: 2017-06-27 22:35 UTC by Dale Turner
Modified: 2017-07-17 07:12 UTC (History)
13 users (show)

Fixed In Version: python-blivet-2.1.9-2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-17 07:12:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (103.20 KB, text/plain)
2017-06-27 22:35 UTC, Dale Turner
no flags Details
File: environ (529 bytes, text/plain)
2017-06-27 22:35 UTC, Dale Turner
no flags Details
File: lsblk_output (1.43 KB, text/plain)
2017-06-27 22:35 UTC, Dale Turner
no flags Details
File: nmcli_dev_list (1.33 KB, text/plain)
2017-06-27 22:35 UTC, Dale Turner
no flags Details
File: os_info (529 bytes, text/plain)
2017-06-27 22:35 UTC, Dale Turner
no flags Details

Description Dale Turner 2017-06-27 22:35:17 UTC
Description of problem:
Attempted to return to the main anaconda screen from the installation destination hub

Version-Release number of selected component:
anaconda-27.16-1

The following was filed automatically by anaconda:
anaconda 27.16-1 exception report
Traceback (most recent call first):
  File "/usr/lib/python3.6/site-packages/blivet/partitioning.py", line 140, in get_next_partition_type
    max_logicals = disk.getMaxLogicalPartitions()
  File "/usr/lib/python3.6/site-packages/blivet/partitioning.py", line 769, in allocate_partitions
    new_part_type = get_next_partition_type(disklabel.parted_disk)
  File "/usr/lib/python3.6/site-packages/blivet/partitioning.py", line 604, in do_partitioning
    allocate_partitions(storage, disks, partitions, free)
  File "/usr/lib/python3.6/site-packages/blivet/autopart.py", line 514, in do_autopart
    do_partitioning(storage)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/kickstart.py", line 328, in execute
    do_autopart(storage, ksdata, min_luks_entropy=MIN_CREATE_ENTROPY)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/kickstart.py", line 2455, in doKickstartStorage
    ksdata.autopart.execute(storage, ksdata, instClass)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 452, in _doExecute
    doKickstartStorage(self.storage, self.data, self.instclass)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 475, in _doExecute
    raise e
  File "/usr/lib64/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.6/site-packages/pyanaconda/threading.py", line 252, in run
    threading.Thread.run(self)
AttributeError: 'Disk' object has no attribute 'getMaxLogicalPartitions'

Additional info:
addons:         com_redhat_docker, com_redhat_kdump
cmdline:        /usr/libexec/system-python  /sbin/anaconda
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         4.12.0-0.rc6.git3.1.fc27.x86_64
product:        Fedora
release:        Cannot get release name.
type:           anaconda
version:        rawhide

Comment 1 Dale Turner 2017-06-27 22:35:23 UTC
Created attachment 1292478 [details]
File: anaconda-tb

Comment 2 Dale Turner 2017-06-27 22:35:24 UTC
Created attachment 1292479 [details]
File: environ

Comment 3 Dale Turner 2017-06-27 22:35:25 UTC
Created attachment 1292480 [details]
File: lsblk_output

Comment 4 Dale Turner 2017-06-27 22:35:27 UTC
Created attachment 1292481 [details]
File: nmcli_dev_list

Comment 5 Dale Turner 2017-06-27 22:35:28 UTC
Created attachment 1292482 [details]
File: os_info

Comment 6 Adam Williamson 2017-06-28 03:27:08 UTC
Similar problem has been detected:

Occurs on completing INSTALLATION DESTINATION spoke in today's Rawhide compose (20170627.n.0). Did not occur in 20170626.n.0. All openQA tests are failing on this crash.

addons:         com_redhat_kdump, com_redhat_docker
cmdline:        /usr/libexec/system-python  /sbin/anaconda
hashmarkername: anaconda
kernel:         4.12.0-0.rc6.git3.1.fc27.x86_64
package:        anaconda-27.16-1
product:        Fedora
reason:         AttributeError: 'Disk' object has no attribute 'getMaxLogicalPartitions'
release:        Cannot get release name.
version:        rawhide

Comment 7 Adam Williamson 2017-06-28 03:39:06 UTC
Proposing as an F27 Alpha blocker, this obviously violates all kinds of criteria (it seems to be more or less impossible to avoid).

Comment 8 Adam Williamson 2017-06-28 03:49:15 UTC
This is caused by a change in pyparted 3.11.0, which landed in the affected Rawhide compose:

https://github.com/dcantrell/pyparted/commit/5cdc96ade4847ba46fc0bf54df9bcec426368924

(note to dcantrell: it makes searching for stuff a lot easier if you include the *name* of the removed function in the commit message...)

Comment 9 Matthew Almond 2017-07-07 21:15:38 UTC
There's a corresponding change in blivet 2.1-devel that resolves this: https://github.com/storaged-project/blivet/commit/d81ed9e8eb4eb861927276b1632ff1a49263fc20

It seems like it's going in the right direction. Is there any way to get this into  the release branch?

Comment 10 Matthew Almond 2017-07-13 23:49:10 UTC
Ah, it looks like it happened: https://github.com/storaged-project/blivet/commit/56a1278203dc3842a53686a9a0899f92af57f81a

Comment 11 Adam Williamson 2017-07-14 00:49:19 UTC
Matthew: when someone changes the status to MODIFIED and sets Fixed In Version, that basically means that the fix will show up in the next python-blivet (or anaconda, they use the same process) build, when it happens.

Comment 12 Vojtech Trefny 2017-07-17 07:12:17 UTC
Matthew: Adam is right, I did a new build with this fix 2 weeks ago, just without doing a new upstream release first. This bug should be already fixed in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.