Created attachment 1305347 [details]
[patch] Update to 1.0.15 (#1475812)

Latest upstream release: 2.0.1
Current version/release in rawhide: 1.0.14-5.fc29
URL: https://github.com/jonathanslenders/python-prompt-toolkit

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8742/

Latest upstream release: 2.0.2
Current version/release in rawhide: 1.0.14-5.fc29
URL: https://github.com/jonathanslenders/python-prompt-toolkit

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8742/

Latest upstream release: 2.0.3
Current version/release in rawhide: 1.0.14-5.fc29
URL: https://github.com/jonathanslenders/python-prompt-toolkit

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8742/

So, how to update it?

> Version 2.0 includes a big refactoring of the internal architecture. This
> includes the merge of the CommandLineInterface and the Application object, a
> rewrite of how user controls are focused, a rewrite of how event loops work
> and the removal of the buffers dictionary. This introduces many backwards
> incompatible changes, but the result is a very nice and powerful architecture.

https://github.com/jonathanslenders/python-prompt-toolkit/blob/2.0.3/CHANGELOG#L29-L33

Based on that, it seems this would only be appropriate for Rawhide.

I updated all the branches to 1.0.15.  Next I'm going to look into renaming the package and subpackages from python{,2,3}-prompt_toolkit to python{,2,3}-prompt-toolkit.

> Package names SHOULD be in lower case and use dashes in preference to underscores.

https://fedoraproject.org/wiki/Packaging:Naming#General_Naming

At the same time, I'll update it to 2.x.x.

Looking forward to it.

Latest upstream release: 2.0.4
Current version/release in rawhide: 1.0.15-1.fc29
URL: https://github.com/jonathanslenders/python-prompt-toolkit

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/8742/

This is needed for IPython 7. Carl, do you need help? Are there any challenges, blockers...?

http://fedora.portingdb.xyz/pkg/python-prompt_toolkit/

"Please notice that this is prompt_toolkit 2.0. It is incompatible with the 1.0 branch, but much better in many regards. Many applications are still using prompt_toolkit 1.0, but upgrading is strongly recommended. Feel free to open a new issue if you don’t manage to upgrade to prompt_toolkit 2.0."

There is a handful of packages that require this:

  sagemath
  ptpython
  python-softlayer
  spyder
  aws-shell
  gns3-server
  ipython
  mycli
  xonsh
  python2-ipython

So we might need to check them one by one.

Hey Miro.  I'd like to change the name from prompt_toolkit to prompt-toolkit, so I'm working on submitting python-prompt-toolkit for review.  I'm aware of the other packages that require prompt_toolkit.  Some of these have had upstream work to get compatible with the update.  This is what I've found so far, any help tracking down the status for the rest would be great.

python3-ipython: https://github.com/ipython/ipython/pull/11177 (done in 7.0.0)
xonsh: https://github.com/xonsh/xonsh/pull/2716 (done in 0.7.0)
ptpython3: https://github.com/jonathanslenders/ptpython/issues/256 (done in master, not released)
mycli: https://github.com/dbcli/mycli/pull/614 (not done)

For the normal rename process [0], I would have python3-prompt-toolkit obsolete python3-prompt_toolkit.  However, since not all the other packages are compatible yet, do you think it would permissible for both python3-prompt_toolkit-1.x.x and python3-prompt-toolkit-2.x.x to exist in rawhide at the same time with no obsolete?  I think I could accomplish it with a "Conflicts" that I later change to an "Obsoletes" once nothing else .  On a related note, upstream considered a prompt_toolkit2 rename, but decided against it [1].

[0]: https://fedoraproject.org/wiki/Package_Renaming_Process
[1]: https://github.com/jonathanslenders/python-prompt-toolkit/issues/568

> do you think it would permissible for both python3-prompt_toolkit-1.x.x and python3-prompt-toolkit-2.x.x to exist in rawhide at the same time with no obsolete?  

No, they would conflict, that's not a good idea.

Do you really think that all the work with renaming this is worth it? Cannot you just rename the subpackages and leave the main package name be?

Yes, I think it's worth it, so that python3-prompt-toolkit has the expected python-prompt-toolkit SRPM/spec name.  I have submitted the re-review.

https://bugzilla.redhat.com/show_bug.cgi?id=1634091

More relevant bugs for the other packages:

aws-shell: https://github.com/awslabs/aws-shell/issues/209
gns3-server: https://github.com/GNS3/gns3-server/pull/1374
python{2,3}-softlayer: https://github.com/softlayer/softlayer-python/issues/1042
python{2,3}-spyder: https://bugzilla.redhat.com/show_bug.cgi?id=1634141
sagemath: https://bugzilla.redhat.com/show_bug.cgi?id=1634174

I noticed something curious with ipython.  The python2 subpackage was dropped from the spec file, but the last version that had it still exists in rawhide.  I expected the python2 subpackage to disappear once new builds without it were published.

- python2-ipython-5.8.0-1.fc29
- python3-ipython-6.4.0-4.fc29

When will python2-ipython actually be removed from Fedora?

See https://src.fedoraproject.org/rpms/python2-ipython

No plans for removal yet.

https://github.com/ipython/ipython/issues/11341

Got a reply at https://github.com/ipython/ipython/issues/11341

Proposal:

We only update python3-prompt-toolkit to 2.x.
We keep python2-prompt-toolikit at 1.x.

(This would work for IPython packages we have in Fedora.)


This would mean ptpython, python-softlayer, spyder woudl need to support both, drop python2, or split as well.

python-prompt-toolkit re-review: bug 1634091
python2-prompt-toolkit re-review: bug 1634819

> We only update python3-prompt-toolkit to 2.x.
> We keep python2-prompt-toolikit at 1.x.

Good. Python 2 packages can always be run in virtualenv.

These have been built for rawhide, they should show up in the next compose.

- python2-prompt-toolkit-1.0.15-3.fc30
- python3-prompt-toolkit-2.0.5-1.fc30

Don't forget to retire python-prompt_toolkit.

Done.