Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1482095 - Review Request: arduino-listSerialPortsC - Simple multiplatform program to list serial ports with vid/pid/iserial fields
Summary: Review Request: arduino-listSerialPortsC - Simple multiplatform program to li...
Keywords:
Status: ON_QA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-08-16 12:52 UTC by Tom "spot" Callaway
Modified: 2017-09-01 11:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Tom "spot" Callaway 2017-08-16 12:52:10 UTC 
Spec URL: https://spot.fedorapeople.org/arduino-1.8/arduino-listSerialPortsC.spec
SRPM URL: https://spot.fedorapeople.org/arduino-1.8/arduino-listSerialPortsC-1.4.0-1.fc26.src.rpm
Description: Simple environment to test libserialport in a single build machine fashion.
Fedora Account System Username: spot
Copr Build: https://copr.fedorainfracloud.org/coprs/spot/arduino-1.8/package/arduino-listSerialPortsC/

Note: This is a new dependency needed to upgrade to Arduino 1.8.
Comment 1 Neal Gompa 2017-08-16 12:59:57 UTC 
Taking this review.
Comment 2 Neal Gompa 2017-08-16 13:31:28 UTC 
Review notes:

* Package is named correctly
* Package builds and installs correctly
* Package follows general packaging guidelines correctly
* rpmlint produced errors

rpmlint errors:
arduino-listSerialPortsC.x86_64: E: arch-dependent-file-in-usr-share /usr/share/arduino/lib/liblistSerialsj.so

This is as intended, so I'm going to ignore it.


Issues to fix on import:
* Changelog entry has the wrong version reference

Otherwise, looks good. Please fix the changelog entry on import.

PACKAGE APPROVED.
Comment 3 Gwyn Ciesla 2017-08-17 13:38:28 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/arduino-listSerialPortsC
Comment 4 Gwyn Ciesla 2017-08-17 13:38:37 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/arduino-listSerialPortsC
Comment 5 Fedora Update System 2017-09-01 11:50:35 UTC 
arduino-1.8.4-1.fc26, arduino-builder-1.3.25-1.fc26, arduino-listSerialPortsC-1.4.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0a69429bd
Note You need to log in before you can comment on or make changes to this bug.