*** Bug 1161834 has been marked as a duplicate of this bug. ***

How does this new program related to "girl", which is shipped by rpmfusion?

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485
 -> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3693

The program gnome-internet-radio-locator replaces it and is based on GTK+ 3.0, GNOME Maps, libchamplain and gst-player.

new version 1.0.2 is available.

Spec URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator-1.1.0-1.fc27.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

I have built RPM packages for testing:

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc27.src.rpm

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

I have built RPM packages for fc27 and fc28.

https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc27.x86_64.rpm
https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc28.x86_64.rpm

https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc27.src.rpm
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm

1. where is the correct link to the SOURCE file: gnome-internet-radio-locator-1.1.1.tar.xz

2. the Group Tag isn't need any longer, please remove it from the spec file.
Group:          Applications/Internet

3. Can you use the %{url} macro in Source0
Source:         %{url}/%{name}-%{version}.tar.xz

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.2-1.fc28.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

I have built gnome-internet-radio-locator 1.1.2 for rawhide:

https://koji.fedoraproject.org/koji/taskinfo?taskID=26591016

I have built a RPM package for fc28 x86_64 from the SRPM:

https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.2-1.fc28.x86_64.rpm

please correct your spec file again !

rpmlint reports:

rpmlint -i -v gnome-internet-radio-locator.x86_64: W: incoherent-version-in-changelog 1.1.2-2 ['1.1.2-1.fc29', '1.1.2-1']

a better description for the %changelog section would:

%changelog
* Fri Apr 27 2018 Ole Aamot <ole> - 1.1.2-1
- Update to 1.1.2

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.2-1.fc28.src.rpm

please remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor theme cache

All those scriptles are no longer needed because in hicolor-icon-theme
package has file triggers updating theme cache on any change in single
dnf/rpm transaction.

https://pagure.io/packaging-committee/issue/736

remove this part from the spec file:

/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

%postun
if [ $1 -eq 0 ] ; then
    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.3-1.fc28.src.rpm

Build for rawhide on koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26593257

1. please remove %post from the spec file

2. please change the description in the %changelog section to

%changelog
* Fri Apr 27 2018 Ole Aamot <ole> - 1.1.3-1
- Update to 1.1.3

1. I have removed %post and built and published 1.1.3-3 for Fedora Core 28.

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.3-3.fc28.src.rpm

2. I prefer to keep the style for %changelog comments since version 0.1.0.

(In reply to ole from comment #15)
> 1. I have removed %post and built and published 1.1.3-3 for Fedora Core 28.
> 
> Spec URL:
> https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
> SRPM URL:
> https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.
> 3-3.fc28.src.rpm

good

> 2. I prefer to keep the style for %changelog comments since version 0.1.0.

I do not agree with that.

Your Changelog entries should provide a brief summary of the changes done to the package. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

* Mon May 07 2018 Ole Aamot <ole> - 1.1.3-3
- gnome-internet-radio-locator 1.1.3 build on Fedora Linux

that are completely useless information, like the name of the program and for which
version the program was built.

This is a short and meaningful description:

* Mon May 07 2018 Ole Aamot <ole> - 1.1.3-3
- Update to 1.1.3

There is no such thing as useless information.

There is no useless information in the ChangeLog entry.

I have written the software, I release the software and
I maintain the released version for the Fedora release.

I have built 1.4.0-0 on Fedora Core 28 and my ChangeLog entry describes this.

Spec URL:
https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec

SRPM URL:
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.4.0-1.fc28.src.rpm

please remove %post from the spec file, it's empty and not needed.

 - Remove %post

 - Run %make_build after %configure

 - Appdata file should now be installed in /usr/share/metainfo . Patch your install scrip appropriately.


appstream-util validate-relax --nonet %{buildroot}/%{_metainfodir}/%{name}.appdata.xml


%{_metainfodir}/%{name}.appdata.xml

Can you remove the DEBIAN file as I doubt the content is useful for Fedora.


%doc AUTHORS DEBIAN NEWS README TODO ChangeLog

no feedback ...

I have built 1.6.0-0 on Fedora Core 28.

Spec URL:
https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec

SRPM URL:
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.6.0-1.fc28.src.rpm

Sources:
https://download.gnome.org/sources/gnome-internet-radio-locator/1.6/gnome-internet-radio-locator-1.6.0.tar.xz

Why does playback of stations on the map markers for

London, United Kingdom
Oslo, Norway
Stockholm, Sweden
Ayr, Scotland

not work on Hewlett Packard with European Regulatory Address running Fedora Core 28?

 - Add gcc as a BR:

BuildRequires:  gcc

 - This is the same file:

%{_bindir}/%{name}
%{_bindir}/gnome-internet-radio-locator

 - The Version-Release in your %changelog entry should be 1.6.0-1



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: BUILDSTDERR: warning: File listed twice: /usr/bin/gnome-internet-
  radio-locator
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* GNU General Public License (v3)", "FSF All
     Permissive License", "GPL (v2 or later)", "GPL (v3 or later)",
     "Unknown or generated", "GNU Lesser General Public License (v2 or
     later)", "GNU Lesser General Public License (v2.1 or later)", "Expat
     License", "FSF Unlimited License (with Retention) GNU General Public
     License", "FSF Unlimited License (with Retention)". 88 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/gnome-internet-radio-locator/review-gnome-
     internet-radio-locator/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/icons/hicolor/1024x1024/apps,
     /usr/share/icons/hicolor/1024x1024
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gnome-
     internet-radio-locator-debuginfo , gnome-internet-radio-locator-
     debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gnome-internet-radio-locator-1.6.0-1.fc30.x86_64.rpm
          gnome-internet-radio-locator-debuginfo-1.6.0-1.fc30.x86_64.rpm
          gnome-internet-radio-locator-debugsource-1.6.0-1.fc30.x86_64.rpm
          gnome-internet-radio-locator-1.6.0-1.fc30.src.rpm
gnome-internet-radio-locator.x86_64: W: spelling-error %description -l en_US gstreamer -> streamer, g streamer, steamer
gnome-internet-radio-locator.x86_64: W: incoherent-version-in-changelog 1.6.0-0 ['1.6.0-1.fc30', '1.6.0-1']
gnome-internet-radio-locator.src: W: spelling-error %description -l en_US gstreamer -> streamer, g streamer, steamer
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

I have built RPM packages for fc29 x86_64:

https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-2.0.0-1.fc29.x86_64.rpm
https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-2.0.0-1.fc29.x86_64.rpm

https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm

I have not yet released 2.0.0 upstream, but I plan to release it as soon as I get feedback on RPMS.

LGTM, package approved.

You still need to find a sponsor however.

Spec URL: http://www.gnomeradio.org/~ole/fedora/SPECS/gnome-internet-radio-locator.spec
SRPM URL: http://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-3.6.0-1.fc32.src.rpm
Description: Locate and stream Internet Radio stations from graphical, zoomable map
Fedora Account System Username: oka

I have built RPM packages for fc32 x86_64:

http://www.gnomeradio.org/~ole/fedora/RPMS/x86_64/gnome-internet-radio-locator-3.6.0-1.fc32.x86_64.rpm
http://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-3.6.0-1.fc32.src.rpm

I have not yet released 4.0.0 upstream, but I plan to release it as soon as I get feedback on the RPMS.

gnome-radio 0.1.0 is in fc33, while gnome-internet-radio-locator 3.6.0 is not part of rawhide and fc33.

See https://linuxreviews.org/GNOME_Internet_Radio_Locator_3.0.5_Is_Released_With_More_Radio_Stations
and http://www.gnomeradio.org/~ole/GUADEC2020.pdf

Best,
Ole

Your package is already approved you list need to find someone to sponsor you into the packager group.

See https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group