Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1535384 - Review Request: tomb - a CLI tool to manage encrypted storage
Summary: Review Request: tomb - a CLI tool to manage encrypted storage
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2018-01-17 09:42 UTC by Blaine Story
Modified: 2020-08-10 00:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:57:35 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Blaine Story 2018-01-17 09:42:55 UTC
This is my first package and I am seeking a sponsor.

* SPEC URL: https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702333-tomb/tomb.spec

* SRPM URL: https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702333-tomb/tomb-2.5-2.fc28.src.rpm

* Description: Tomb is a zsh script that uses commonly shared components such as cryptsetup to make it simple to generate encrypted storage folders. (https://www.dyne.org/software/tomb/)

* Fedora Account System Username: blainester

It is already on COPR: https://copr.fedorainfracloud.org/coprs/blainester/tomb/

Comment 1 Artur Frenszek-Iwicki 2018-01-17 11:08:59 UTC
>Patch0: tomb.patch
Ideally, patches should have some description of what they it. It can either be part of the patch name (like "tomb-do-not-use-usr-env.patch"), or a #comment in the spec.

>%make_install PREFIX=/usr
Use "%{_prefix}" instead of "/usr".

As a style remark, %install is usually put before %files. It might also be good to write a simple comment like "# Nothing to build" in the %build section. The %description could also be a bit longer; the text on the Tomb website seems friendly enough for this purpose.

Comment 2 Blaine Story 2018-01-17 20:05:47 UTC
Thank you for your fixes. I have implemented them in my COPR repo and it built just fine.

Here are my updated SPEC and SRPM URLs:

https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702599-tomb/tomb.spec

https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702599-tomb/tomb-2.5-3.fc28.src.rpm

Comment 3 Artur Frenszek-Iwicki 2018-01-17 20:52:21 UTC
One thing I haven't noticed earlier is that you're not packaging the licence text. You should include the licence (COPYING.txt) using the %license macro. You can read more here:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

You may also consider including some files as documentation (%doc macro).
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

Another thing that's good to do is doing a scratch koji build ("koji build --scratch") of your package and posting the result in this ticket. This way whoever is reviewing the package can be sure it will build properly in the Fedora build system.

Before you can get sponsored, you will also need to do some package reviews. This does not mean doing "full" reviews, just posting some comments. You should visit the review request queue once in a while, look for new requests, see if you can spot any mistakes and report them (or report that everything seems fine).

I do not have sponsor privileges, but I hope this few bits of advice will help you on your way.

Comment 4 Blaine Story 2018-01-17 21:47:56 UTC
I have included COPYING.txt to the %license macro and added a few files (including the manpage) to %doc. 

There are several PDF files bundled with the upstream tarball which do deep dives into encryption that I have opted to not include because it would increase the RPM filesize from 57kb to several megabytes for items which are only tangentially related to the package.

Updated SPEC and SRPM:

* https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702627-tomb/tomb.spec

* https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702627-tomb/tomb-2.5-4.fc28.src.rpm

Koji builds:

* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249594
* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249578
* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249529

I'm still rather new to RPM packaging but will give what advice I can to pending review requests.

Thank you for helping me get this far.

Comment 5 Robert-André Mauchin 🐧 2018-10-04 19:19:51 UTC
Using:

* SPEC URL: https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00793623-tomb/tomb.spec

* SRPM URL: https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00793623-tomb/tomb-2.5-4.fc30.src.rpm


 - The man page must not be marked as %doc:

%{_mandir}/man1/tomb.1*

 - Might be cool to add subpackages for the extras:

# Extras

Tomb comes with a bunch of extra tools that contribute to enhance its
functionality or integrate it into particular system environments.

## extras/gtk-tray

The Gtk tray adds a nifty tomb skull into the desktop toolbar: one can
use it to close, slam and explore the open tomb represented by it.

When using pinentry-gtk-2 it also adds a little skull on the password
input, useful to not confuse it with other password inputs.

To have it change directory `extras/gtk-tray` then

 1. make sure libnotify and gtk+-2.0 dev packages are available
 2. run `make` inside the directory to build `tomb-gtk-tray`
 3. run `sudo make install` (default PREFIX is `/usr/local`)
 4. start `tomb-gtk-tray tombname` after the tomb is open

Of cource one can include the launch of tomb-gtk-tray scripts.

## extras/qt-tray

The QT tray adds a tomb tray in a QT desktop toolbar. It requires at
least QT libraries of version 5.4 or above.
Build with 'qmake' and then 'make'.

Comment 6 Package Review 2020-07-10 00:56:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2020-08-10 00:57:35 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.