Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1538977 - kabi-dw: Do not build with Address Sanitizer
Summary: kabi-dw: Do not build with Address Sanitizer
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kabi-dw
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zamir SUN
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1537488 Fedora28ElfLinking
TreeView+ depends on / blocked
 
Reported: 2018-01-26 10:03 UTC by Florian Weimer
Modified: 2018-01-31 14:30 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-31 14:30:49 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2018-01-26 10:03:13 UTC 
The package is currently being built with Address Sanitizer.  This is not supported in Fedora because libasan does not provide any ABI stability, so toolchain upgrades can break kabi-dw.
Comment 1 Zamir SUN 2018-01-29 09:16:06 UTC 
Hi Stanislav,

I've filed a pull request to resolve this. Can you check if you are willing to merge it?
https://github.com/skozina/kabi-dw/pull/4

And I also thought about disable asan for debug builds totally, and move asan support to a separate make target. In case you are interested in that way, it was still available here 
https://github.com/sztsian/kabi-dw/commit/3787e1650a59682ff2872fa27ae7822e96b8376d
Comment 2 Stanislav Kozina 2018-01-29 11:20:42 UTC 
Jerome,

Can you please take a look at Zamir's commits above and share your thoughts? I tend decline the pull request and disable asan for debug builds, ie. the other commit. Thanks!
Comment 3 Jerome Marchand 2018-01-29 13:20:21 UTC 
(In reply to Stanislav Kozina from comment #2)
> Jerome,
> 
> Can you please take a look at Zamir's commits above and share your thoughts?
> I tend decline the pull request and disable asan for debug builds, ie. the
> other commit. Thanks!

Yes, I would go with that too: if libasan causes ABI stability trouble, it's probably safer to remove it from the debug build by default.
Comment 4 Zamir SUN 2018-01-29 13:33:39 UTC 
Oh, sure. I will rebase the pull request to the other commit.
Comment 5 Zamir SUN 2018-01-29 13:39:21 UTC 
Just updated the pull request to the commit which disabled asan.
Comment 6 Zamir SUN 2018-01-31 14:30:49 UTC 
This is fixed in 0-0.5-20180130git545535a
https://src.fedoraproject.org/rpms/kabi-dw/c/0462cec7aaab283a4446d5a9e7404213a51d3852?branch=master
Note You need to log in before you can comment on or make changes to this bug.