Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1543845 - nss: Build flags injection only partially successful
Summary: nss: Build flags injection only partially successful
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nss
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-09 12:22 UTC by Florian Weimer
Modified: 2018-06-21 13:03 UTC (History)
4 users (show)

Fixed In Version: nss-3.37.3-1.1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-21 13:03:25 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2018-02-09 12:22:01 UTC 
/usr/bin/certutil and other programs in nss-tools-3.35.0-4.fc28.x86_64 are not linked with the standard LDFLAGS from redhat-rpm-config.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md
Comment 1 Fedora End Of Life 2018-02-20 15:24:48 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.
Comment 2 Daiki Ueno 2018-03-12 16:00:28 UTC 
I simply added "LDFLAGS=$RPM_LD_FLAGS; export LDFLAGS" in the spec:
https://src.fedoraproject.org/rpms/nss/c/03874d12724f28a6df4d78e48d8315a6d8e423dc?branch=master
and the build seems to pick up the correct flags:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25659474

This might be suboptimal; maybe we could:
- respect $LDFLAGS already set in the shell environment
- introduce a separate make variable, e.g., XLDFLAGS analogous to XCFLAGS
Comment 3 Daiki Ueno 2018-06-21 13:03:25 UTC 
This should be fixed in the current update of the nss package.  Feel free to reopen if it is not the case.
Note You need to log in before you can comment on or make changes to this bug.