Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1546883 - dnf preferring fedora-modular-release to fedora-release in image composes since dnf-2.7.5-8.fc28 (breaks Rawhide installer image repos)
Summary: dnf preferring fedora-modular-release to fedora-release in image composes sin...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-modular-release
Version: 28
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F28BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2018-02-19 21:42 UTC by Adam Williamson
Modified: 2018-02-22 19:44 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-21 12:30:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2018-02-19 21:42:05 UTC
Current Fedora Rawhide installer image composes are rather broken because they contain fedora-modular-release and fedora-modular-repos , not fedora-release and fedora-repos . This causes them to try and use a non-existent repository and fail to be able to set up packaging at all.

This changed between Fedora-Rawhide-20180212.n.0 and Fedora-Rawhide-20180213.n.0 (though we didn't notice till today as both those composes, and all between 20180204.n.0 and 20180218.n.0, ultimately failed entirely for other reasons).

https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20180212.n.0/logs/x86_64/buildinstall-Everything.x86_64.log
https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20180213.n.0/logs/x86_64/buildinstall-Everything.x86_64.log

Those are the 'Everything' buildinstall logs for the two composes in question (the logs for other variants are similar). Note that in 20180212.n.0 'fedora-release', 'fedora-repos' and 'fedora-repos-rawhide' are installed, but in 20180213.n.0, 'fedora-modular-release' and 'fedora-modular-repos' are installed (there is no 'fedora-modular-repos-rawhide').

I made a diff of all the packages between those two composes. There are quite a lot as it was in the middle of the mass rebuild, but one obvious suspect leaps out: dnf-2.7.5-8.fc28 . The changelog for that build says:

* Mon Feb 12 2018 Daniel Mach <dmach> - 2.7.5-8
- Rebase to dnf from dnf-2-modularity branch.

so this certainly looks like it could be the cause.

I *suspect* that ultimately nothing in the package set pulled in by lorax during these image composes specifically requires fedora-release; instead there is at least one package (setup - there may be others too) that requires system-release. system-release is provided by fedora-release, fedora-modular-release and generic-release, so we're relying on dnf to pick 'the right one' there, somehow. I think something in the 'dnf-2-modularity' branch causes it to prefer fedora-modular-release to satisfy that requirement where previously it preferred fedora-release. That is only my suspicion, though, there may be some other explanation.

Proposing as a Fedora 28 Beta blocker, as a violation of "...Release-blocking network install images must default to a valid publicly-accessible package source." - https://fedoraproject.org/wiki/Basic_Release_Criteria#Remote_package_sources . This is violated for the Everything network install image, which does not do that any more.

Comment 1 Adam Williamson 2018-02-19 22:17:09 UTC
BTW, it occurs to me to wonder whether fedora-modular-release should actually exist at all any more, with the new Modularity plan: https://fedoraproject.org/wiki/Changes/F28AddonModularity

Comment 2 Fedora End Of Life 2018-02-20 15:32:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 3 Dennis Gilmore 2018-02-20 18:33:37 UTC
it does not need to exist in the new world, I have retired it

Comment 4 Daniel Mach 2018-02-21 12:30:05 UTC
The fedora-modular-release was probably picked by depsolver.
You need to specify fedora-release manually if you want to include it as a priority package.
I don't think this is a bug.

Comment 5 Adam Williamson 2018-02-22 19:44:15 UTC
Well, it's not entirely that simple, but in any case, we solved this a different way: the package has been retired. I've verified that recent composes are back to using fedora-release and fedora-repos.


Note You need to log in before you can comment on or make changes to this bug.