Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1548757 - pidgin: Partial build flags injection
Summary: pidgin: Partial build flags injection
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: pidgin
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Synacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-24 20:06 UTC by Florian Weimer
Modified: 2019-11-27 19:22 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 19:22:33 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2018-02-24 20:06:54 UTC 
Many components of pidgin are not linked with the official Fedora linker flags (LDFLAGS) from redhat-rpm-config, e.g. /usr/lib64/gnt/irssi.so in finch-2.12.0-8.fc28.x86_64 or /usr/lib64/purple-2/psychic.so in libpurple-2.12.0-8.fc28.x86_64.

This is likely due to the use of libtool:

libtool: link: gcc -shared  -fPIC -DPIC  .libs/tmpone_time_password.so.o   -lgadu -lm -lresolv  -g -O2 -g -fstack-protector-strong -grecord-gcc-switches -m64 -mtune=generic -mcet -Wl,-z -Wl,relro   -Wl,-soname -Wl,libtmpone_time_password.so.so -o .libs/libtmpone_time_password.so.so

(-specs=/usr/lib/rpm/redhat/redhat-hardened-ld is missing.)

This may mostly be fixed with the redhat-rpm-config change in bug 1548397 (starting with redhat-rpm-config-101-1.fc28).  Perhaps a simple rebuild will fix the lack of BIND_NOW hardening.

On the other hand, this may cause issues with the pidgin plugin system if shared objects are not loaded in the right order, to match their symbol dependencies.
Comment 1 Jan Synacek 2018-02-27 09:05:00 UTC 
I actually don't know what to do with this one. I'm going to start with the rebuild.
Comment 2 Jan Synacek 2018-02-27 09:25:14 UTC 
@Florian, does this look like it's working?

https://kojipkgs.fedoraproject.org//work/tasks/583/25340583/build.log
Comment 3 Florian Weimer 2018-02-27 10:11:33 UTC 
(In reply to Jan Synacek from comment #2)
> @Florian, does this look like it's working?
> 
> https://kojipkgs.fedoraproject.org//work/tasks/583/25340583/build.log

I downloaded the RPMs and they look okay.  Note that enabling BIND_NOW could have some non-desirable interactions with plugin loaders (we know that there are issues with X server loadable modules and zsh plugins).  This means that some testing is needed.
Comment 4 Jan Kurik 2018-08-14 11:08:04 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.
Comment 5 Ben Cotton 2019-10-31 20:44:52 UTC 
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 6 Ben Cotton 2019-11-27 19:22:33 UTC 
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.
Note You need to log in before you can comment on or make changes to this bug.